[pulseaudio-discuss] [PATCH RFCv3 11/51] pstream: Add pa_pstream_send_tagstruct()

[David Henningsson]

On 2014-11-05 00:26, Peter Meerwald wrote:
> From: Peter Meerwald <p.meerwald at bct-electronic.com>
>
> don't encapsulate a tagstruct in a packet anymore, allow to
> pass the tagstruct directly to the pstream
>
> this removes the ugly macro pa_pstream_send_tagstruct()
> in pstream-util.h and calls the new function pa_pstream_send_tagstruct()
> causing the addition of a NULL parameters in many places

If you think a macro is ugly, how about:

void pa_pstream_send_tagstruct_ancil(pa_pstream*p, pa_tagstruct 
*tagstruct, const pa_cmsg_ancil_data *ancil_data);

static inline void pa_pstream_send_tagstruct(pa_pstream*p, pa_tagstruct 
*tagstruct) {
     pa_pstream_send_tagstruct_ancil(p, tagstruct, NULL);
}


Also, this creates a dependency on tagstruct from the pstream, which I'm 
a little hesitant about.
I'd like more opinions about whether that would be okay or not, what do 
others think?

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic