[pulseaudio-discuss] [PATCH 6/8] launch: Add systemd units for launching pulseaudio user instances

Colin Guthrie gmane at colin.guthr.ie
Tue Nov 11 07:50:53 PST 2014


Tanu Kaskinen wrote on 11/11/14 15:12:
> On Mon, 2014-11-10 at 16:55 +0000, Colin Guthrie wrote:
>> Tanu Kaskinen wrote on 10/11/14 16:29:
>>> Are you sure installing to /usr/local/lib/systemd/user doesn't work? To
>>> me path-lookup.c looks like it includes /usr/local/lib/systemd/user in
>>> the unit search paths.
>>
>> Hmm, yeah looks like it. It's not documented in the documentation tho',
>> (I was looking through through "man systemd.unit" which describes all
>> the paths) and I've not not seen this behaviour in other projects that
>> support this pkgconfig stuff (and I've seen a fair few when packaging
>> stuff downstream), so with combined with the fact that this is how
>> pretty much everything else does things and the fact that the udev rules
>> already work like this, I don't really fancy introducing something off
>> the beaten path here, but if you do feel strongly, I can certainly look
>> into it.
> 
> I'll write a documentation patch for systemd, and if it gets accepted,
> then we could install under /usr/local?

If we must, but I'd really rather have a defined, clean way to get the
folder name from pkgconfig for this purpose too, and I really don't see
why us deviating from the way it's done in all the other projects really
makes things that much better overall, but if you feel strongly, then go
for it.

I do think it will be quite hard to support this scheme when you pass
e.g. --prefix /home/colin/builds/pa/ and it somehow still knows to put
the units in /usr/local (obviously it doesn't make sense to use
$prefix/systemd/user/ as a path as this only works for two very specific
values of $prefix (three if you count /etc as prefix but you'd have to
be pretty mad to do that!)).

Personally I'd rather leave it as it is, and just suggest to people to
use $XDG_CONFIG_HOME/systemd/user/ when doing their own builds as their
own user or use /usr/local/systemd/system/user/ when using a /usr/local
prefix. If logic around this could be made available in e.g. an
appropriate autotools include that lots of packages could use then
that's fine by me. I just don't like the idea of every project doing
something homegrown and different; systemd is providing so much benefit
from standardising things I'd hate to see that undone with small
convenience hacks littered around everywhere (even if they are sensible
enough in principle).

So yeah, fixing one problem causes another IMO and we certainly
shouldn't pretend that using /home/colin/builds/pa/systemd/user/ as a
path is in any way valid as a default choice.

If it is fixed for this tho', then it should also be fixed for the udev
rules.

/me never uses /usr/local anyway even for his own builds, so my interest
in it is somewhat limited, but I certainly won't stand in the way.


Col





-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/


More information about the pulseaudio-discuss mailing list