[pulseaudio-discuss] [PATCH 04/13] tests: Use single-line #ifdef for ARM NEON code

Peter Meerwald pmeerw at pmeerw.net
Thu Sep 11 07:33:13 PDT 2014


> > Since the line
> > #if defined (__arm__) && defined (__linux__) && defined (HAVE_NEON)
> > 
> > gets repeated a lot, it makes me wonder if we could just do a
> > 
> > #if defined (__arm__) && defined (__linux__) && defined (HAVE_NEON)
> > #define HAVE_ARM_LINUX_NEON
> > #else
> > #undef HAVE_ARM_LINUX_NEON
> > #endif
> > 
> > ...instead. Not sure if HAVE_NEON could ever be defined without __arm__
> > either?

don't think so, NEON implies ARM

> This seems to have remained unchanged in v2, and you did not comment on it
> either?

I missed that (probably should check if where is more #define madness)

thanks, p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)


More information about the pulseaudio-discuss mailing list