[pulseaudio-discuss] [PATCH v2 08/25] echo-cancel: Mark private function as static

[Arun Raghavan]

On Wed, 2015-12-16 at 07:11 +0200, Tanu Kaskinen wrote:
> On Wed, 2015-12-16 at 09:09 +0530, arun at accosted.net wrote:
> > From: Arun Raghavan <git at arunraghavan.net>
> > 
> > ---
> >  src/modules/echo-cancel/webrtc.cc | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/modules/echo-cancel/webrtc.cc b/src/modules/echo-
> > cancel/webrtc.cc
> > index 3be7fe5..a8b69b5 100644
> > --- a/src/modules/echo-cancel/webrtc.cc
> > +++ b/src/modules/echo-cancel/webrtc.cc
> > @@ -78,9 +78,9 @@ static int routing_mode_from_string(const char
> > *rmode) {
> >          return -1;
> >  }
> >  
> > -void pa_webrtc_ec_fixate_spec(pa_sample_spec *rec_ss,
> > pa_channel_map *rec_map,
> > -                              pa_sample_spec *play_ss,
> > pa_channel_map *play_map,
> > -                              pa_sample_spec *out_ss,
> > pa_channel_map *out_map)
> > +static void pa_webrtc_ec_fixate_spec(pa_sample_spec *rec_ss,
> > pa_channel_map *rec_map,
> > +                                     pa_sample_spec *play_ss,
> > pa_channel_map *play_map,
> > +                                     pa_sample_spec *out_ss,
> > pa_channel_map *out_map)
> >  {
> >      rec_ss->format = PA_SAMPLE_S16NE;
> >      play_ss->format = PA_SAMPLE_S16NE;
> 
> The pa_ prefix should be dropped for static functions, and "webrtc"
> (maybe also "ec") seems redundant too.

Will fix that and speex' similar usage up in a separate commit.

-- Arun