[pulseaudio-discuss] [PATCH] module-loopback: Bugfix for 6.0

Georg Chini georg at chini.tk
Sat Jan 31 13:05:27 PST 2015


During my work on module-loopback I found a bug that sometimes crashes pulse when
module-loopback is loaded due to pushing a zero-length block into the memblockq.
As there is a one-line fix I thought you might want it for 6.0.

---
 src/modules/module-loopback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/modules/module-loopback.c b/src/modules/module-loopback.c
index e17051a..7e2b92a 100644
--- a/src/modules/module-loopback.c
+++ b/src/modules/module-loopback.c
@@ -272,7 +272,7 @@ static void source_output_push_cb(pa_source_output *o, const pa_memchunk *chunk)
     pa_source_output_assert_io_context(o);
     pa_assert_se(u = o->userdata);
 
-    if (u->skip > chunk->length) {
+    if (u->skip >= chunk->length) {
         u->skip -= chunk->length;
         return;
     }
-- 
2.1.4



More information about the pulseaudio-discuss mailing list