[pulseaudio-discuss] [PATCH] resampler: Don't expose soxr methods if they are not supported

[Arun Raghavan]

On 6 November 2015 at 13:50, David Henningsson
<david.henningsson at canonical.com> wrote:
>
>
> On 2015-11-06 06:45, arun at accosted.net wrote:
>>
>> From: Arun Raghavan <git at arunraghavan.net>
>>
>> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=92780
>> ---
>>   src/pulsecore/resampler.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c
>> index bf3fdb8..df2458d 100644
>> --- a/src/pulsecore/resampler.c
>> +++ b/src/pulsecore/resampler.c
>> @@ -655,9 +655,11 @@ static const char * const resample_methods[] = {
>>       "auto",
>>       "copy",
>>       "peaks",
>> +#ifdef HAVE_SOXR
>>       "soxr-mq",
>>       "soxr-hq",
>>       "soxr-vhq"
>> +#endif
>
>
> Eh, no? Shouldn't the resample_methods array follow the pa_resample_method_t
> enum? (Where the SOXR stuff is always exposed, and probably should be?)

Hum, you're right, of course. Sent this out in a hurry. Updated patch incoming.

Thanks,
Arun