[pulseaudio-discuss] [PATCH] bluetooth: Prevent aborts caused by invalid module arguments

Arun Raghavan arun at accosted.net
Mon Jan 11 19:51:06 PST 2016


On Mon, 2016-01-11 at 08:08 -0800, Jason Gerecke wrote:
> Hadn't noticed the lack of goto in module-bluetooth-policy.c... Given
> that it seems to be the usual pattern, would it be preferable to send
> a set of two patches: the first swapping out the "return -1" for a
> "goto fail" in module-bluetooth-policy.c:pa__init and the second
> patch
> being this one?

That's generally the preference but in this case, either could be fine
since it's also okay to group small but logically similar fixes in a
single change.

Cheers,
Arun


More information about the pulseaudio-discuss mailing list