<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:宋体;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Comic Sans MS";
panose-1:3 15 7 2 3 3 2 2 2 4;}
@font-face
{font-family:"\@宋体";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
p
{mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:宋体;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Comic Sans MS";
color:windowtext;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
/* Page Definitions */
@page Section1
{size:595.3pt 841.9pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;
layout-grid:15.6pt;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=ZH-CN link=blue vlink=purple style='text-justify-trim:punctuation'>
<div class=Section1 style='layout-grid:15.6pt'>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>Previous
mail is blocked due to large size, I separate the patch into 3, this is the
first one.<o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'><o:p> </o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>Hi,
Lennart<o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>Sorry
for being late, was fully occupied by other tasks. <o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'><o:p> </o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>I
modified the volume ramping feature per your suggestions.<o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>1,
rewind envelop when rewinding sink-input. And keep the envelop around until
i->sink->max_rewind is processed after the envelop is finished.<o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>2,
make all envelop manipulation inside the IO context, main thread just set the
pa_envelope_def and then send out SET_ENVELOPE message to let IO thread create
the envelop. And this will make it possible to create envelope in other places,
not just inside set_volume_with_ramping set_mute_with_ramping. <o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>3,
future_volume, future_mute is introduced to avoid distortion before envelop
takes effect, e.g. when unmute, if you change the thread_info.muted
immediately, you will hear a short loud sound before ramping up takes effect,
future_mute could avoid this issue. <o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>4,
do not apply sink’s volume when setting ramp info. Since it does not help a lot
to avoid calculation overflow.<o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'><o:p> </o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>I
do not use pa_envelope_replace, it seems envelope_replace is intend to replace
the pa_envelope_def inside pa_envelope_item, our code only has one
pa_envelope_def, if I call replace, it’s like replace myself with myself, I’m
not sure if that is proper.<o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>I’m
sorry I didn’t have time to make envelop be able to aware of balancing stuff,
will it be possible to make it as a future enhancement? <o:p></o:p></span></font></p>
<p class=MsoNormal style='layout-grid-mode:char'><font size=2
face="Comic Sans MS"><span lang=EN-US style='font-size:10.0pt;font-family:"Comic Sans MS"'>Thanks
for your review!<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="Comic Sans MS"><span lang=EN-US
style='font-size:10.0pt;font-family:"Comic Sans MS"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="Comic Sans MS"><span lang=EN-US
style='font-size:10.0pt;font-family:"Comic Sans MS"'><o:p> </o:p></span></font></p>
<p style='margin:0cm;margin-bottom:.0001pt'><font size=1 face="Comic Sans MS"><span
lang=EN-US style='font-size:7.5pt;font-family:"Comic Sans MS"'>Best Regards,
Zheng, Huan(ZBT)<o:p></o:p></span></font></p>
<p style='margin:0cm;margin-bottom:.0001pt'><font size=1 face="Comic Sans MS"><span
lang=EN-US style='font-size:7.5pt;font-family:"Comic Sans MS"'>OTC/SSD/SSG</span></font><span
lang=EN-US><o:p></o:p></span></p>
<p style='margin:0cm;margin-bottom:.0001pt'><font size=1 face="Comic Sans MS"><span
lang=EN-US style='font-size:7.5pt;font-family:"Comic Sans MS"'>Intel
Asia-Pacific Research & Developement Ltd</span></font><span lang=EN-US><o:p></o:p></span></p>
<p style='margin:0cm;margin-bottom:.0001pt'><font size=1 face="Comic Sans MS"><span
lang=EN-US style='font-size:7.5pt;font-family:"Comic Sans MS"'>Tel: 021-6116
6435</span></font><span lang=EN-US><o:p></o:p></span></p>
<p style='margin:0cm;margin-bottom:.0001pt'><font size=1 face="Comic Sans MS"><span
lang=EN-US style='font-size:7.5pt;font-family:"Comic Sans MS"'>Inet: 8821 6435</span></font><span
lang=EN-US><o:p></o:p></span></p>
<p style='margin:0cm;margin-bottom:.0001pt'><font size=1 face="Comic Sans MS"><span
lang=EN-US style='font-size:7.5pt;font-family:"Comic Sans MS"'>Cub: 3W035</span></font><span
lang=EN-US><o:p></o:p></span></p>
<p class=MsoNormal><font size=2 face="Times New Roman"><span lang=EN-US><o:p> </o:p></span></font></p>
</div>
</body>
</html>