<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 01/08/2009, at 12:55 AM, Lennart Poettering wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><blockquote type="cite"><br></blockquote><br>Please, next time attach them uncompressed and inline, makes it easier<br>to comment on.<font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><div><br></div>Ok - but historically newgroup readers have tend to flame people who add 20K+ of patches inline on a discussion group....</div><div>Times change.</div><div><br></div><div><blockquote type="cite"><div>Also, could you please split those patches into logical units?<br>i.e. one patch that adds the clock_xxxx stuff, and another one that<br>adds the semaphore stuff?<font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><div><br></div>Hmmm. I probably can but it's going to take me a number of hours to sort out and I can't do it until later next the week.</div><div>If you _have_ to have it let me know and I'll try and get around to it.</div><div>I understand they are orthogonal edits but surely they are of relatively little value individually?</div><div>I have always tended to commit a logically related and self consistent set of changes - in this case "make OS X compile/run".</div><div>Is it a "git" mindset or a "PA" mindset to commit minimal deltas ?</div><div>I will stay minimal in future.</div><div><br></div><div><blockquote type="cite"><div>Also, you'd do me a great favour if you could follow the rules pointed<br>out here:<br><br><a href="http://pulseaudio.org/wiki/CodingStyle">http://pulseaudio.org/wiki/CodingStyle</a><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><div><br></div>I say tom-ah-to .. you say tom-a-to.</div><div>I've read it now.</div><div style="text-align: left;">I happen to voilently disagree with point 3 :-) given space is not a problem these days. I *like* my braces to line up vertically. Its far more elegant IMHO than opening braces way off in never-never land on RHS of screen.</div><div style="text-align: left;">Still at least you're very sensible with 4 space indents. I just don't get these 3-space indent weirdos!!! :-)</div><div style="text-align: left;">I'm getting too old and grumpy to follow everyone else's preferences but I'll try next time :-)</div><div><br><blockquote type="cite"><div>(/me doesn't like // comments, they are so C++ish...)<br></div></blockquote><div><br></div>They're way more efficient and IMHO one of the few nice things C++ added. Don't throw the baby out with the bath water.</div><div>I've been to uni lectures by Ken Thompson so I *know* old style but I love // they are BEAUTIFUL and minimalistic not ugly. ;-)</div><div>But I accept "your project ... your rules"</div><div><br><blockquote type="cite"><div><blockquote type="cite">* There is a README.OSX file that should cover everything you need to <br></blockquote><blockquote type="cite">know about what I did and the changes I made.<br></blockquote><blockquote type="cite"><span class="Apple-tab-span" style="white-space:pre"> </span>Maybe someone can add them to the wiki (I'm not game just yet to go <br></blockquote><blockquote type="cite">charging in and editing things that might only work for me :-) ).<br></blockquote><br>I think most of this should be documented in the commit msgs or even<br>in comments, or in the wiki.</div></blockquote><div><br></div>Is there a recommended maximum length/style for commit messages?</div><div>Surely you wouldn't want most of that README in a commit message - I don't mind - I didn't see any wiki commit message standards/recommendations.</div><div><br></div><div><blockquote type="cite"><div><blockquote type="cite">* Calls to clock_* have been replaced with pa_clock_* wrapper except <br></blockquote><blockquote type="cite">for the one file alsa-time-test.c where there didn't seem any point<br></blockquote><blockquote type="cite">!?<br></blockquote><br>Sounds good. pa_clock_settime() should be dropped though, since we<br>don't need that, do we?<br></div></blockquote><div><br></div><div>Probably but it's a threesome group of missing functions. I was just trying to be complete...</div><div>I was thinking of creating a standard "missing" library for OS X that others could use in the future.</div><div>I'm actually somewhat surprised no-one else appears to have done it. Maybe it should be added into the configure system but that's beyond my mental capacity just now. No actually configure is beyond my mental capacity period. :-)</div><div><br></div><div>BTW someone added in a line to configure.ac recently:</div><div>AC_DEFINE([_POSIX_C_SOURCE], [200112L], [Needed to get clock_gettime on Mac OS X])</div><div>AFAIK that line will have no effect wrt clock_gettime because Apple appears not to have implemented it anywhere. Someone please correct me if I am wrong here. </div></div><div><br><blockquote type="cite"><div>Hmm, any chance bootstrap_osx.sh could be merged with bootstrap.sh?<font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><div><br></div>Agreed. In theory the essence of bootstrap_osx.sh (ie without the PATH etc) could replace most/all of bootstrap.sh.</div><div>bootstrap_osx.sh seems cleaner, however bootstrap.sh may be doing other subtle things or supporting other platforms/versions in a way I don't know. So I left it separate temporarily until someone has tried a version of boostrap_osx.sh on linux at least.</div><div><br><blockquote type="cite"><div>Regarding the dump modules issue: why does every lib exists twice,<br>once preloaded and once not preloaded? That's weird. Does the problem<br>go away if you disable preloading?<br><br></div></blockquote>I had removed the force preload (at least in my first version) yet the modules still appeared. TBA.</div><div><br><blockquote type="cite"><div>Otherwise looks good.<br><br></div></blockquote>Ta.</div><div><br></div><div><blockquote type="cite"><div>Lennart<br><br>-- <br>Lennart Poettering Red Hat, Inc.<br>lennart [at] poettering [dot] net<br><a href="http://0pointer.net/lennart/">http://0pointer.net/lennart/</a> GnuPG 0x1A015CC4<br>_______________________________________________<br>pulseaudio-discuss mailing list<br><a href="mailto:pulseaudio-discuss@mail.0pointer.de">pulseaudio-discuss@mail.0pointer.de</a><br>https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss<br></div></blockquote></div><br></body></html>