<br><br><div class="gmail_quote">2011/8/5 Pierre-Louis Bossart <span dir="ltr"><<a href="mailto:pierre-louis.bossart@linux.intel.com">pierre-louis.bossart@linux.intel.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <div class="im">> during mmap_write(), there's chance to increase/decrease watermark. So<br> > before<br> > sleep, the actural sleep time should based on latest watermark.<br> </div>[snip]<br> <div class="im">> @@ -787,6 +787,7 @@ static int unix_write(struct userdata *u, pa_usec_t<br> > *sleep_usec, pa_bool_t polle<br> <br> </div>Change makes sense, but this should be done both for unix_write and<br> mmap_write for consistency. And while I am at it for alsa-source as well, we<br> should keep the same algorithm across all cases.<br></blockquote><div><br></div><div>Thanks your review, Pierre.</div><div>And Sorry for late reply, i was fighting for some bugs.</div><div><br></div><div>Please find attached update patch based on your suggestions, which should fulfill the requirement. :-)</div> <div><br></div><div>--xingchao</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"> <font color="#888888">-Pierre<br> </font><div><div></div><div class="h5"><br> <br> <br> <br> _______________________________________________<br> pulseaudio-discuss mailing list<br> <a href="mailto:pulseaudio-discuss@lists.freedesktop.org">pulseaudio-discuss@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss" target="_blank">http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss</a><br> </div></div></blockquote></div><br>