Hi Col,<div><br></div><div>Pls find attached updated patch, it works fine on my Meego platform.</div><div>Feel free to let me know if there's any risk.</div><div><br></div><div>--xingchao</div><div><br>2011/8/11 Colin Guthrie <<a href="mailto:gmane@colin.guthr.ie">gmane@colin.guthr.ie</a>>:<br>
> 'Twas brillig, and Colin Guthrie at 05/08/11 12:41 did gyre and gimble:<br>>> 'Twas brillig, and xing wang at 05/08/11 05:46 did gyre and gimble:<br>>>> Hi,<br>>>><br>>>> Does anyone has comment on this patch?<br>
>><br>>> Sorry, I forgot about this one. I had it marked as unread, but it fell<br>>> of the bottom of my unread list. Thanks very much for pinging it up again.<br>>><br>>> I think it looks good, but I'll go over it with a few people in the next<br>
>> few days! It's certainly a problem, so it needs fixed and this patch<br>>> looks like the right fix on first glance.<br>><br>> OK, so this causes the following assert:<br>><br>> E: [alsa-sink] sink-input.c: Assertion<br>
> 'PA_SINK_INPUT_IS_LINKED(i->thread_info.state)' failed at<br>> ../../src/pulsecore/sink-input.c:1049, function<br>> pa_sink_input_update_max_request(). Aborting.<br>><br>><br>> This is done when a stream is in a START_CORKED state I believe (paplay<br>
> triggered it).<br>><br>> Either way this cannot be done yet.... can you come up with a better<br>> patch that doesn't break paplay and friends?<br>><br>> Col<br>><br>><br>><br>><br>><br>
> --<br>><br>> Colin Guthrie<br>> gmane(at)<a href="http://colin.guthr.ie">colin.guthr.ie</a><br>> <a href="http://colin.guthr.ie/">http://colin.guthr.ie/</a><br>><br>> Day Job:<br>> Tribalogic Limited [<a href="http://www.tribalogic.net/">http://www.tribalogic.net/</a>]<br>
> Open Source:<br>> Mageia Contributor [<a href="http://www.mageia.org/">http://www.mageia.org/</a>]<br>> PulseAudio Hacker [<a href="http://www.pulseaudio.org/">http://www.pulseaudio.org/</a>]<br>> Trac Hacker [<a href="http://trac.edgewall.org/">http://trac.edgewall.org/</a>]<br>
><br>> _______________________________________________<br>> pulseaudio-discuss mailing list<br>> <a href="mailto:pulseaudio-discuss@lists.freedesktop.org">pulseaudio-discuss@lists.freedesktop.org</a><br>> <a href="http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss">http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss</a><br>
><br><br></div>