<div class="gmail_quote">在 2012年3月21日 下午3:21，David Henningsson <span dir="ltr"><<a href="mailto:david.henningsson@canonical.com">david.henningsson@canonical.com</a>></span>写道：<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 03/20/2012 03:48 PM, rong deng wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
This is Deng Zhenrong from Shanghai China, I've already used Linux as my<br>
main desktop for several years. Now I would like to express my interests<br>
in applying pulseaudio's projects for this year's GSoC in this mail.<br>
</blockquote>
<br></div>
Hi Deng and welcome to PulseAudio! :-)<br>
<br></blockquote><div><br></div><div>Hi David,</div><div><br></div><div>Thanks for replying this message. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
More contributors are always welcome. As for GSoC, I have never mentored anyone and won't be able to do so this summer either, so I'll let somebody else answer to that.<div class="im"><br></div></blockquote><div>
<br></div><div>No problem. :-)</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Glancing through the ideas, I find I'm interested in several few<br>
already. :) But I'd like to focus on one thing which is test/log<br>
facilities for now. I'm still doing my homework on this topic and I'll<br>
come up with more detailed info in later days.<br>
<br>
So to get my hands dirty, I've already downloaded pulseaudio source code<br>
and compile it and set it up. Now I find there's a compilation warning,<br>
and here's my patch to fix it, cool :)<br>
<br>
I'm attaching the patch generated from git format-patch, I'm not sure<br>
whether it's OK, as I see it from the mailing list, other developers<br>
send patches directly in mails. This patch is my first one to get<br>
familiar with the workflow, if there's anything wrong, please tell me. :)<br>
</blockquote>
<br></div>
As for the patch, I believe you did most things right. :-) Some people prefer you send the patch using "git send-email", but for me, it does not matter much.<br>
<br></blockquote><div><br></div><div>OK. I'll try to use "git send-email" for later patches. I haven't set up this mail system yet, I'll try to figure it out...</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
As for using the PRI-prefixes, it seems we do not use this anywhere else in the code. Therefore I have two questions:<br>
<br>
1) Do you think there is a risk that some compiler that we want to build PulseAudio under, does not support these prefixes (remember, this is not only used in Linux, but in Windows, Mac OS, OS/2 IIRC and others)?<br>
<br></blockquote><div><br></div><div>No, I don't think it's a risk, as this PRI-prefix is defined in inttypes.h header file, and according to manual, it is a standard.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2) Would "%llx" solve this warning equally well?<span class="HOEnZb"><font color="#888888"><br>
<br></font></span></blockquote><div> </div><div>On 32-bit system, yes, but then, it's not portable.</div><div>To print uin64_t on 32 bit system, we should use %llx,</div><div>but to print it on 64 bit system, we should use %lx instead. PRI-prefix help us handle this.</div>
<div><br></div><div>Yes, there IS another way to handle, we can explicitly cast 'pa_channel_position_mask_t' to 'unsigned long long' and use %llx.</div><div><br></div><div>It's up to you guys whether it should use PRI-prefix or use this cast. I'm OK with these both methods. :)</div>
<div><br></div><div>--rong</div></div>