<html><body><div style="color:#000; background-color:#fff; font-family:verdana, helvetica, sans-serif;font-size:10pt"><div><span>Hello.</span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><span>Ths change fixed SIGABORT.</span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><span>-----------------</span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family:
verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><span>diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c<br>index 3b55e82..1156ffa 100644<br>--- a/src/modules/alsa/alsa-ucm.c<br>+++ b/src/modules/alsa/alsa-ucm.c<br>@@ -361,7 +361,7 @@ static int ucm_get_modifier_property(pa_alsa_ucm_modifier *modifier, snd_use_cas<br> <br> /* Create a list of devices for this verb */<br> static int ucm_get_devices(pa_alsa_ucm_verb *verb, snd_use_case_mgr_t *uc_mgr) {<br>- const char **dev_list;<br>+ const char **dev_list = NULL;<br> int num_dev, i;<br> <br> num_dev = snd_use_case_get_list(uc_mgr, "_devices", &dev_list);<br>@@ -384,7 +384,7
@@ static int ucm_get_devices(pa_alsa_ucm_verb *verb, snd_use_case_mgr_t *uc_mgr) {<br> };<br> <br> static int ucm_get_modifiers(pa_alsa_ucm_verb *verb, snd_use_case_mgr_t *uc_mgr) {<br>- const char **mod_list;<br>+ const char **mod_list = NULL;<br> int num_mod, i;<br> <br> num_mod = snd_use_case_get_list(uc_mgr, "_modifiers", &mod_list);<br></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><span>--------------------------</span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent;
font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: verdana,helvetica,sans-serif; background-color: transparent; font-style: normal;"><span>Sajeesh<br></span></div><div><br></div> <div style="font-family: verdana, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> sajeesh sidharthan <sajeesh.sidharthan@yahoo.com><br> <b><span style="font-weight: bold;">To:</span></b> "pulseaudio-discuss@lists.freedesktop.org" <pulseaudio-discuss@lists.freedesktop.org> <br> <b><span style="font-weight: bold;">Sent:</span></b> Sunday, June 16, 2013 11:53 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> [pa-ucm] SIGABORT in ucm_get_modifiers<br> </font> </div> <div class="y_msg_container"><br><div
id="yiv5469222557"><div><div style="color:#000;background-color:#fff;font-family:verdana, helvetica, sans-serif;font-size:10pt;"><div>Hello.<br><br>I have come across SIGABORT in pulse-ucm module.<br><br>SIGABORT
happened due to freeing memory of uninitialized pointer in
ucm_get_modifiers(). If modifier list count is 0, alsa-ucm doesnt return
error and doesnt allocate memory for modifier list.<br>
<br>In ucm_get_modifiers, mod_list is uninitialized and this leads to
freeing memory which is not allocated inside alsa-ucm, by calling
snd_use_case_free_list().<br><br>Please let me know if I can checkin the code to fix the crash.</div><div class="yiv5469222557yj6qo yiv5469222557ajU"><div class="yiv5469222557ajR"><img class="yiv5469222557ajT" src="https://mail.google.com/mail/u/0/images/cleardot.gif"></div></div><span class="yiv5469222557HOEnZb yiv5469222557adL"><font color="#888888">/Sajeesh</font></span></div></div></div><br><br></div> </div> </div> </div></body></html>