<div dir="ltr">Hi Tanu,<div><br></div><div>Can you please review my new patchset?</div><div><br></div><div>Regards,</div><div>Kiran</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Oct 10, 2013 at 8:01 PM, Kiran Krishnappa <span dir="ltr"><<a href="mailto:kiraank@gmail.com" target="_blank">kiraank@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi,</div><div><br></div>I tested both paplay and parecord for 24bit files. Looks to be working fine now.<div>
<br></div><div>Regards,</div><div>Kiran<br><div><br></div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Oct 9, 2013 at 11:30 PM, Kiran Krishnappa <span dir="ltr"><<a href="mailto:kiraank@gmail.com" target="_blank">kiraank@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not<br>
handled in pa_sndfile_readf and writef function. paplay/parecord<br>
used to get aborted for 24bit depth wav files<br>
---<br>
src/pulsecore/sndfile-util.c | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/pulsecore/sndfile-util.c b/src/pulsecore/sndfile-util.c<br>
index 0820ee4..a951c01 100644<br>
--- a/src/pulsecore/sndfile-util.c<br>
+++ b/src/pulsecore/sndfile-util.c<br>
@@ -384,6 +384,7 @@ pa_sndfile_readf_t pa_sndfile_readf_function(const pa_sample_spec *ss) {<br>
<br>
case PA_SAMPLE_ULAW:<br>
case PA_SAMPLE_ALAW:<br>
+ case PA_SAMPLE_S24NE:<br>
return NULL;<br>
<br>
default:<br>
@@ -407,6 +408,7 @@ pa_sndfile_writef_t pa_sndfile_writef_function(const pa_sample_spec *ss) {<br>
<br>
case PA_SAMPLE_ULAW:<br>
case PA_SAMPLE_ALAW:<br>
+ case PA_SAMPLE_S24NE:<br>
return NULL;<br>
<br>
default:<br>
<span><font color="#888888">--<br>
1.7.9.5<br>
<br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>