[Bug 37443] compile errors on RHEL in display/gnome-rr.c

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon May 23 02:03:37 PDT 2011


--- Comment #3 from Christophe Fergeau <teuf at gnome.org> 2011-05-23 02:03:37 PDT ---
Review of attachment 47028:
 --> (https://bugs.freedesktop.org/review?bug=37443&attachment=47028)

2 small questions, but all in all it looks good to me.

::: gtk/display/gnome-rr.c
@@ +76,3 @@

+#if !GLIB_CHECK_VERSION(2,26,0)

I have a slight preference for #ifndef G_DEFINE_BOXED_TYPE in case it ever
becomes deprecated, or in case someone builds with glib 2.25.x, or stuff like
that, but all of these things are really unlikely, so I'm fine with the

@@ +542,3 @@
                 guint32       *config_timestamp_ret)
+    GnomeRRScreenPrivate *priv G_GNUC_UNUSED;

I'm not sure why this change was needed? Is that something unwanted that crept

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the spice-bugs mailing list