[Spice-commits] Changes to 'spice.v5.1'
Gerd Hoffmann
kraxel at kemper.freedesktop.org
Wed May 5 05:28:54 PDT 2010
New branch 'spice.v5.1' available with the following commits:
commit bd5f46f95546c98f11d480aec9ddf9a493a3e8f6
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Mon May 3 21:29:55 2010 +0200
qxl: byteorder fixups (wip)
commit c122af777f35ed836e4ab6bb275a0c64f749f805
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Fri Apr 23 13:28:21 2010 +0200
spice: live migration (wip).
Handle spice client migration, i.e. inform a spice client connected
about the new host and connection parameters, so it can move over the
connection automatically.
commit e689329f0584f1301071d9088f8266f28162f48f
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Fri Mar 12 16:26:18 2010 +0100
spice: add pci vdi port backend (obsolete).
This is *not* intended to be merged upstream. It is just here
because the virtio-serial windows guest drivers are not ready,
so you can't go with the new spice-vmc yet.
commit 15fd6ea04b7d0c4498ee94586a20cad8f42bef4d
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Tue Apr 20 13:33:54 2010 +0200
spice: add virtio-serial based vdi port backend.
Adds the spicevmc device. This is a communication channel between the
spice client and the guest. It is used to send display information and
mouse events from the spice clients to the guest.
commit 4af5979e2ff6a2bbd0f01a688eb8a738b6d8c23b
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Tue Apr 13 10:34:46 2010 +0200
spice: add audio
Add support for the spice audio interface.
The driver is first in the driver list, but can_be_default is set only
in case spice is active. So if you are using spice the spice audio
driver is the default one, otherwise whatever comes first after spice in
the list. Overriding the default using QEMU_AUDIO_DRV works in any
case.
commit 989dd9ef04488928c5b848b7efe540000755fe9c
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Tue Apr 13 09:05:03 2010 +0200
spice: add tablet support
Add support for the spice tablet interface. The tablet interface will
be registered (and then used by the spice client) as soon as a absolute
pointing device is available and used by the guest, i.e. you'll have to
configure your guest with '-usbdevice tablet'.
commit d1eb34ee6e141e064ebb3237a010642d3e1cfa29
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Tue Apr 27 11:50:11 2010 +0200
spice: add qxl device
qxl is a paravirtual graphics card. The qxl device is the bridge
between the guest and the spice server (aka libspice-server). The
spice server will send the rendering commands to the spice client, which
will actually render them.
The spice server is also able to render locally, which is done in case
the guest wants read something from video memory. Local rendering is
also used to support display over vnc and sdl.
qxl is activated using "-vga qxl". qxl supports multihead, additional
cards can be added via '-device qxl".
commit 6ba1588cee5f2ca28bb194972441172aa7138884
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Thu Mar 11 11:13:32 2010 -0300
spice: tls support
Add options to the -spice command line switch to setup tls:
tls-port
listening port
x509-dir
x509 file directory. Expects same filenames as
-vnc $display,x509=$dir
x509-key-file
x509-key-password
x509-cert-file
x509-cacert-file
x509-dh-key-file
x509 files can also be set individually.
tls-ciphers
which ciphers to use.
commit c9ac0cb6a0382bddc8808cca6f274d1c532615e8
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Wed Mar 24 15:47:18 2010 +0100
spice: simple display
With that patch applied you'll actually see the guests screen in the
spice client. This does *not* bring qxl and full spice support though.
This is basically the qxl vga mode made more generic, so it plays
together with any qemu-emulated gfx card. You can display stdvga or
cirrus via spice client. You can have both vnc and spice enabled and
clients connected at the same time.
commit 47d6a04434e07c3f81bef69b2e277cda2b79cc2e
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Thu Mar 11 11:13:29 2010 -0300
spice: add mouse
Open mouse channel. Now you can move the guests mouse pointer.
No tablet / absolute positioning (yet) though.
commit a2cecf36be11139bdd6dd6df3f483fcb4746fd03
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Thu Mar 11 11:13:28 2010 -0300
spice: add keyboard
Open keyboard channel. Now you can type into the spice client and the
keyboard events are sent to your guest. You'll need some other display
like vnc to actually see the guest responding to them though.
commit c38f538c1d73832cd37e7f0abc2c7793d4f8047d
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Thu Mar 11 11:13:27 2010 -0300
spice: core bits
Add -spice command line switch. Has support setting passwd and port for
now. With this patch applied the spice client can successfully connect
to qemu. You can't do anything useful yet though.
commit b8a65a5a259322aa34a65b1b7554ed894617ea22
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Wed Mar 24 10:26:51 2010 +0100
add spice into the configure file
commit a1b660ebdf75e34855fa7c9d09d2055d05f12f41
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Fri Apr 23 13:44:10 2010 +0200
configure: add logging
commit e910032cc9afa3faba54702fae4aa1eecb82bbd6
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Wed Mar 24 11:16:54 2010 +0100
vgabios update to 0.6c, add bios for qxl/unstable
commit b95981c681881913983f68981ad72779fb302b6f
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Fri Apr 30 15:58:03 2010 +0200
vnc: rich cursor support.
Uses VNC_ENCODING_RICH_CURSOR. Adding XCURSOR support should be
possible without much trouble. Shouldn't be needed though as
RICH_CURSOR is a superset of XCURSOR.
commit b4e6fe13f68d269485aeb597a5e64448dbf603a4
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Tue May 4 12:49:04 2010 +0200
use new cursor struct + functions for vmware vga and sdl.
commit e2e03f11f2b6ef1a1d75aa959a85c047e5676ed8
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Tue May 4 12:26:15 2010 +0200
cursor: add cursor functions.
Add a new cursor type to console.h and a bunch of functions to
deal with cursors the (new) cursor.c file.
commit b4b8f39aba1ffd64af59a7660ec4ec20f4160f26
Author: Gerd Hoffmann <kraxel at redhat.com>
Date: Wed Apr 28 20:27:11 2010 +0200
15bpp support (16/555)
commit 262353cb1fd8a78f6f0c9d1ddd2fdce32d3fdf95
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Tue May 4 19:55:35 2010 +0000
Fix cpu list("-cpu ?") breakage, spotted by TeLeMan
Fix breakage by 04c9a0cbc2bf496889cef6da2d61bf00ef190a4f.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 0684bf1b0fa1823bf0614dd8d1c8b10cc0ef3f35
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Tue May 4 08:28:13 2010 -0500
vnc: make sure to send pointer type change event on SetEncodings
Commit 37c34d9d5d87ea9d51760310c8863b82cb8c055a introduced a regression when
using relative mouse mode with a client that understands the PointerTypeChange
pseudo-encoding.
Reported-by: Marcelo Tosatti <mtosatti at redhat.com>
Reported-by: Gerhard Wiesinger <lists at wiesinger.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit ec5f92ce6ac8ec09056be77e03c941be188648fa
Author: Bernhard M. Wiedemann <qemudevbmw at lsmod.de>
Date: Tue Apr 20 20:48:06 2010 +0200
hw: better i440 emulation
updated version of an old patch
http://xenon.stanford.edu/~eswierk/misc/qemu-linuxbios/qemu-piix-ram-size.patch
that together with
http://www.mail-archive.com/linuxbios@linuxbios.org/msg02390.html
(which is already in coreboot trunk) allows coreboot to autodetect the amount of RAM within qemu/kvm from a register in i440 northbridge.
The message on the old patch states:
Unfortunately the current version of qemu does not set these
registers, but I have patched qemu so that it emulates the i440 more
faithfully in this regard.
Signed-off-by: Bernhard M. Wiedemann <qemudevbmw at lsmod.de>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit cb4e5f8ed1b648c451491b10dc92b1af1e324535
Author: Naphtali Sprei <nsprei at redhat.com>
Date: Sun Apr 25 19:30:37 2010 +0300
block: read-only: open cdrom as read-only when using monitor's change command
Current code of monitor command: 'change', used to open file for read-write
uncoditionally. Change to open it as read-only for CDROM, and read-write for all others.
Signed-off-by: Naphtali Sprei <nsprei at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 288e7bccf1719df4d05abc872e75d544089aa139
Author: Nathan Froyd <froydnj at codesourcery.com>
Date: Mon Apr 26 14:52:23 2010 -0700
fix whitespace bogon in some versions of make
With three different make binaries I have available, configuring a
pristine QEMU tree and attempting to make gives the cryptic:
Makefile:27: *** missing separator. Stop.
This patch fixes it (presumably because it makes the output of
`set-vpath' be an empty string, rather than a bit of whitespace), but I
don't understand why this hasn't been a problem for other folks before.
Signed-off-by: Nathan Froyd <froydnj at codesourcery.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 2791104cfb40314110f96dc5eeab98613e5ab1a0
Author: David Ahern <daahern at cisco.com>
Date: Sat Apr 24 10:26:22 2010 -0600
Changes to usb-linux to conform to coding style
Signed-off-by: David Ahern <daahern at cisco.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 0e1a275bd4a9b0eb6a567f21366074bda4a8d336
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Tue Apr 6 13:31:29 2010 +0200
Add KVM CFLAGS to vhost build
The configure test of vhost uses KVM CFLAGS, so the build must use them
as well. Otherwise we specifically miss what --kerneldir provides.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 6ed2c484f261fd8bd217f855b9e5e5f981e63f0a
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Tue Apr 27 20:35:59 2010 -0300
QMP: Introduce RESUME event
It's emitted when the Virtual Machine resumes execution.
We currently have the STOP event but don't have the matching
RESUME one, this means that clients are notified when the VM
is stopped but don't get anything when it resumes.
Let's fix that as it's already causing some trouble to libvirt.
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 3d54abc7b7f234685ea48bdd1743ed631cf02ba0
Author: Gautham R Shenoy <ego at in.ibm.com>
Date: Thu Apr 29 17:45:03 2010 +0530
virtio-9p: Create a syntactic shortcut for the file-system pass-thru
Currently the commandline to create a virtual-filesystem pass-through between
the guest and the host is as follows:
#qemu -fsdev fstype,id=ID,path=path/to/share \
-device virtio-9p-pci,fsdev=ID,mount_tag=tag \
This patch provides a syntactic short-cut to achieve the same as follows:
#qemu -virtfs fstype,path=path/to/share,mount_tag=tag
This will be internally expanded as:
#qemu -fsdev fstype,id=tag,path=path/to/share, \
-device virtio-9p-pci,fsdev=tag,mount_tag=tag \
Signed-off-by: Gautham R Shenoy <ego at in.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 9c5e9d8970d1822246f73be441c363a17ff1cc2c
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:45:02 2010 +0530
virtio-9p: Add P9_TFLUSH support
Don't do anything special for flush.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 5bae190082fc24d8881e5db9409fc94f6c46f219
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:45:01 2010 +0530
virtio-9p: Add P9_TREMOVE support.
Implement P9_TREMOVE support.
This gets file deletion to work.
[mohan at in.ibm.com: Fix truncate to use the relative path]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 8cf89e007a37fff75c06e5a4564d530e51c1ec98
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:45:00 2010 +0530
virtio-9p: Add P9_TWSTAT support
Implement P9_TWSTAT support.
This gets file and directory creation to work.
[jvrao at linux.vnet.ibm.com: strdup to qemu_strdup conversion]
[aneesh.kumar at linux.vnet.ibm.com: v9fs_fix_path]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit c494dd6f28dbacd855bca894c664bf1f9836afe9
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:59 2010 +0530
virtio-9p: Add P9_TCREATE support
Implement P9_TCREATE support.
[jvrao at linux.vnet.ibm.com: strdup to qemu_strdup conversion]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 8449360cbde906bb36ca2181d3723bae2fd10742
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:58 2010 +0530
virtio-9p: Add P9_TWRITE support
Implement P9_TWRITE support.
This gets write to file to work
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit bbd5697b8ea7e8795e83d3550cd1a11077c57fd4
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:57 2010 +0530
virtio-9p: Add P9_TCLUNK support
Implement P9_TCLUNK support.
This patch gets `ls -al` to work.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit a92315553df516a5e3431142aadab93482c6b29f
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:56 2010 +0530
virtio-9p: Add P9_TREAD support
Implement P9_TREAD support.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit a6568fe27fdb50a46109b48612128cf712e60130
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:55 2010 +0530
virtio-9p: Add P9_TOPEN support.
Implement P9_TOPEN support.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit ff5e54c98749ca2e5586cb1cdbb2b97c69c7ee51
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:54 2010 +0530
virtio-9p: Add P9_TWALK support
Implement P9_TWALK support.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 4da7d3fa2d9ad02bdf8abfc741bb882f1f5c482a
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:53 2010 +0530
virtio-9p: Add P9_TSTAT support
Implement P9_TSTAT support. This get the mount to work on the guest.
[kiran at linux.vnet.ibm.com: malloc to qemu_malloc conversion]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 955efc47559fb4475d06a37ce0ab3f3ae8c4cd83
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:52 2010 +0530
virtio-9p: Add P9_TATTACH support.
Implement P9_TATTACH support.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 92c1ad037a4f3081b07ff945eed10a23087866e2
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:51 2010 +0530
virtio-9p: Add P9_TVERSION support
Implement P9_TVERSION support.
[sripathik at in.ibm.com: Handle unknown 9P versions as per the standards]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 1f5a89bf68193012df13dd3eb188783367e489d5
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:50 2010 +0530
virtio-9p: Add sg helper functions
Add scatter-gather helper functions.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit bb9e3216bf32032a08a6f48799991f05203fa54b
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:49 2010 +0530
virtio-9p: Add stat and mode related helper functions.
Add helpers to obtain file stat and mode details.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 286d56526e0ab9b7c9f8b487cbb1ccb280aa5a22
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:48 2010 +0530
virtio-9p: Add fid and qid management support.
Helper APIs for FID and QID management.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 131dcb2521bff704424cdb2ce065dc776fbc89b9
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:47 2010 +0530
virtio-9p: Add minimal set of FileOperations
Add minimal set of FileOperations and the corresponding implementations for
local fstype. These will be required for the FID management patches later on.
[aneesh.kumar at linux.vnet.ibm.com: rpath fix ]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit a03f7874396c909562d35931d03eca79c5c7f708
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:46 2010 +0530
virtio-9p: Add string manipulation support.
Add helpers to do string manipulation.
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 405a549a160ce632826661902aebee71c2e196bb
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:45 2010 +0530
virtio-9p: pdu processing support.
Add helpers to process the PDUs.
[kiran at linux.vnet.ibm.com: malloc to qemu_malloc coversion]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 9f10751365b26b13b8a9b67e0e90536ae3d282df
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Thu Apr 29 17:44:44 2010 +0530
virtio-9p: Add a virtio 9p device to qemu
This patch doesn't implement the 9p protocol handling
code. It adds a simple device which dump the protocol data.
[jvrao at linux.vnet.ibm.com: Little-Endian to host format conversion]
[aneesh.kumar at linux.vnet.ibm.com: Multiple-mounts support]
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 74db920c32cea5b52a91b81f2bfd467fc070e942
Author: Gautham R Shenoy <ego at in.ibm.com>
Date: Thu Apr 29 17:44:43 2010 +0530
virtio-9p: Create a commandline option -fsdev
This patch creates a new command line option named -fsdev to hold any file
system specific information.
The option will currently hold the following attributes:
-fsdev fstype id=id,path=path_to_share
where
fstype: Type of the file system.
id: Identifier used to refer to this fsdev
path: The path on the host that is identified by this fsdev.
[aneesh.kumar at linux.vnet.ibm.com: Abstraction using FsContext]
Signed-off-by: Gautham R Shenoy <ego at in.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar at linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit a1c5975270f2335e1d7129c084a6e562d7b99bdd
Author: Amit Shah <amit.shah at redhat.com>
Date: Fri Apr 30 16:43:55 2010 +0530
virtio-serial: Fix check for 'assert'; prevent NULL derefs
In the flush_queued_data() function, we expect port to be valid. Assert
only for port and not port || discard.
Reported-by: Juan Quintela <quintela at redhat.com>
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit f8778a7785d530515b0db395606f327fd5f94a92
Author: Stefan Berger <stefanb at us.ibm.com>
Date: Sat Apr 24 08:54:07 2010 -0400
Fix the RARP protocol ID
The packet(s) sent out after migration are supposed to be RAPR type of
packets. If they are supposed to go anywhere useful, the RAPR ethernet
identifier needs to be fix.
Also see http://www.iana.org/assignments/ethernet-numbers for 0x8035 for
RARP.
Signed-off-by: Stefan Berger <stefanb at us.ibm.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit d510c5cf343eabd4d3a301f5730af724747b7055
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Thu Apr 29 18:24:43 2010 +0200
Fix tiny leak in qemu_opts_parse
qemu_opts_create duplicates the id we pass in case it shall be stored in
the opts. So we do not need to dup it in qemu_opts_parse, leaking a few
bytes this way.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 54eefd72bfc0ad7cd5cbedba8ef4368bd2bc3329
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Fri Apr 30 14:06:13 2010 +0200
lsi: Properly initialize controller state on reset
The LSI controller was lacking a system reset handler. Simply invoke the
existing soft reset handler in this case. This also allows to drop its
explicit invocation during init.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 51336214da6f2eaa7baaa8efa1823377252c1496
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Fri Apr 30 14:06:12 2010 +0200
lsi: Purge request queue on soft reset
Avoid keeping zombie requests across controller reset by purging the
queue and also dropping the currently active request.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 37905d6ae53d8a9f0744867a8cf2dad6e7ae3674
Author: Alex Williamson <alex.williamson at redhat.com>
Date: Fri Apr 30 15:21:11 2010 -0600
Fix boot once option
The boot once options seems to have gotten broken since it originally
went in. We need to wait until the second time restore_boot_devices()
gets called before restoring the standard boot order and removing itself
from the reset list.
Signed-off-by: Alex Williamson <alex.williamson at redhat.com>
--
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 70a4568fe0c5a64adaa3da5030b7109e5199e692
Author: Corentin Chary <corentincj at iksaif.net>
Date: Mon May 3 14:31:34 2010 +0200
vnc: split encoding in specific files
This will allow to implement new encodings (tight, zrle, ..)
in a cleaner way. This may hurt performances, because some
functions like vnc_convert_pixel are not static anymore, but
should not be a problem with gcc 4.5 and the new -flto.
Signed-off-by: Corentin Chary <corentincj at iksaif.net>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit bc47d201d6868a6ad51a5d2f7f946d0e6b33c5ab
Author: Corentin Chary <corentincj at iksaif.net>
Date: Mon May 3 14:31:18 2010 +0200
vnc: Fix compile error on x86_64 with -D_VNC_DEBUG=1
cc1: warnings being treated as errors
vnc-auth-sasl.c: In function ‘vnc_client_write_sasl’:
vnc-auth-sasl.c:50: error: format ‘%d’ expects type ‘int’, but argument 4 has type ‘size_t’
vnc-auth-sasl.c:50: error: format ‘%d’ expects type ‘int’, but argument 5 has type ‘size_t’
make: *** [vnc-auth-sasl.o] Error 1
Signed-off-by: Corentin Chary <corentincj at iksaif.net>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 72375c2290ef696f49b4fe81da55b8761608f524
Merge: a6dac6a9ab81b1052e052876a67b9fc483b8b337 d748768c09b1f93bea90f660ab0b4063d5e9d88d
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Mon May 3 07:31:51 2010 -0500
Merge remote branch 'kwolf/for-anthony' into HEAD
commit a6dac6a9ab81b1052e052876a67b9fc483b8b337
Merge: ace22f6917849de28d8ba96b7426a0ea64f95369 8369e01ce418edb26a6e1f65406cac650563b3da
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Mon May 3 07:31:37 2010 -0500
Merge remote branch 'qemu-kvm/uq/master' into HEAD
commit d748768c09b1f93bea90f660ab0b4063d5e9d88d
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Thu Apr 29 18:24:50 2010 +0200
block: Release allocated options after bdrv_open
They aren't used afterwards nor supposed to be stored by a bdrv_create
handler.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit cc60e327c0988a5e5288cf7bb78cd9848db800ab
Author: Kevin Wolf <kwolf at redhat.com>
Date: Thu Apr 29 14:47:48 2010 +0200
qemu-img rebase: Fix output image corruption
qemu-img rebase must always give clusters in the COW file priority over those
in the backing file. As it failed to use number of non-allocated clusters but
assumed the maximum, it was possible that allocated clusters were taken from
the backing file instead, leading to a corrupted output image.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 294cc35f3db84017e0c176c15dd9a1b711e8354d
Author: Kevin Wolf <kwolf at redhat.com>
Date: Wed Apr 28 14:34:01 2010 +0200
block: Add wr_highest_sector blockstat
This adds the wr_highest_sector blockstat which implements what is generally
known as the high watermark. It is the highest offset of a sector written to
the respective BlockDriverState since it has been opened.
The query-blockstat QMP command is extended to add this value to the result,
and also to add the statistics of the underlying protocol in a new "parent"
field. Note that to get the "high watermark" of a qcow2 image, you need to look
into the wr_highest_sector field of the parent (which can be a file, a
host_device, ...). The wr_highest_sector of the qcow2 BlockDriverState itself
is the highest offset on the _virtual_ disk that the guest has written to.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 419b19d9b427fad5ff2fa886d8cc217f7acee18c
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Wed Apr 28 11:36:11 2010 +0100
qcow2: Implement bdrv_truncate() for growing images
This patch adds the ability to grow qcow2 images in-place using
bdrv_truncate(). This enables qemu-img resize command support for
qcow2.
Snapshots are not supported and bdrv_truncate() will return -ENOTSUP.
The notion of resizing an image with snapshots could lead to confusion:
users may expect snapshots to remain unchanged, but this is not possible
with the current qcow2 on-disk format where the header.size field is
global instead of per-snapshot. Others may expect snapshots to change
size along with the current image data. I think it is safest to not
support snapshots and perhaps add behavior later if there is a
consensus.
Backing images continue to work. If the image is now larger than its
backing image, zeroes are read when accessing beyond the end of the
backing image.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 003fad6e2cae5311d3aea996388c90e3ab17de90
Author: Kevin Wolf <kwolf at redhat.com>
Date: Wed Apr 21 11:37:52 2010 +0200
qcow2: Remove abort on free_clusters failure
While it's true that during regular operation free_clusters failure would be a
bug, an I/O error can always happen. There's no need to kill the VM, the worst
thing that can happen (and it will) is that we leak some clusters.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit ae6b0ed6d4d4a41e77584f44d2888303645fa845
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Sat Apr 24 09:12:12 2010 +0100
qemu-img: Add 'resize' command to grow/shrink disk images
This patch adds a 'resize' command to grow/shrink disk images. This
allows changing the size of disk images without copying to a new image
file. Currently only raw files support resize.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 51762288b41f59d027073c404a29256fc4d4540e
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Mon Apr 19 16:56:41 2010 +0100
block: Cache total_sectors to reduce bdrv_getlength calls
The BlockDriver bdrv_getlength function is called from the I/O code path
when checking that the request falls within the device. Unfortunately
this involves an lseek system call in the raw protocol; every read or
write request will incur this lseek cost.
Jan Kiszka <jan.kiszka at siemens.com> identified this issue and its
latency overhead. This patch caches device length in the existing
total_sectors variable so lseek calls can be avoided for fixed size
devices.
Growable devices fall back to the full bdrv_getlength code path because
I have not added logic to detect extending the size of the device in a
write.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 4899d10d142e97eea8f64141a3507b2ee1a64f52
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Mon Apr 19 13:34:11 2010 +0100
raw-posix: Use pread/pwrite instead of lseek+read/write
This patch combines the lseek+read/write calls to use pread/pwrite
instead. This will result in fewer system calls and is already used by
AIO.
Thanks to Jan Kiszka <jan.kiszka at siemens.com> for identifying excessive
lseek and Christoph Hellwig <hch at lst.de> for confirming that this
approach should work.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 508e0893686794be55cfaa336fea584b16a471d9
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Sat Apr 17 10:49:07 2010 +0100
qcow2: Avoid shadowing variable in alloc_clusters_noref()
The i loop iterator is shadowed by the next free cluster index. Both
using the variable name 'i' makes the code harder to read.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 557df6aca2e389ef631b283ca1522b1fdf121eff
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Sat Apr 17 10:49:06 2010 +0100
block: Set backing_hd to NULL after deleting it
It is safer to set backing_hd to NULL after deleting it so that any use
after deletion is obvious during development. Happy segfaulting!
This patch should be applied after Kevin Wolf's "vmdk: Convert to
bdrv_open" so that vmdk does not segfault on close.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 6511ef77375100ecf9134f85f08cef31fd196cdf
Author: Kevin Wolf <kwolf at redhat.com>
Date: Fri Apr 16 21:27:51 2010 +0200
vmdk: Convert to bdrv_open
It's a format driver, so implement bdrv_open instead of bdrv_file_open.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 9949f97e84c8040fde6116cb438f2999c52f023a
Author: Kevin Wolf <kwolf at redhat.com>
Date: Fri Apr 16 21:07:19 2010 +0200
vmdk: Clean up backing file handling
VMDK is doing interesting things when it needs to open a backing file. This
patch changes that part to look more like in other drivers. The nice side
effect is that the file name isn't needed any more in the open function.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit c336500df5bf08492f4e7796b2193cd4976f3548
Author: Kevin Wolf <kwolf at redhat.com>
Date: Fri Apr 16 19:28:14 2010 +0200
vmdk: Fix COW
When trying to do COW, VMDK wrote the data back to the backing file. This
problem was revealed by the patch that made backing files read-only. This patch
does not only fix the problem, but also simplifies the VMDK code a bit.
This fixes the backing file qemu-iotests cases for VMDK.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit f2feebbd93c251ec0098a9ccf808f7cb1da7f67c
Author: Kevin Wolf <kwolf at redhat.com>
Date: Wed Apr 14 17:30:35 2010 +0200
block: bdrv_has_zero_init
This fixes the problem that qemu-img's use of no_zero_init only considered the
no_zero_init flag of the format driver, but not of the underlying protocols.
Between the raw/file split and this fix, converting to host devices is broken.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 66f82ceed6781261c09e65fb440ca76842fd0500
Author: Kevin Wolf <kwolf at redhat.com>
Date: Wed Apr 14 14:17:38 2010 +0200
block: Open the underlying image file in generic code
Format drivers shouldn't need to bother with things like file names, but rather
just get an open BlockDriverState for the underlying protocol. This patch
introduces this behaviour for bdrv_open implementation. For protocols which
need to access the filename to open their file/device/connection/... a new
callback bdrv_file_open is introduced which doesn't get an underlying file
opened.
For now, also some of the more obscure formats use bdrv_file_open because they
open() the file themselves instead of using the block.c functions. They need to
be fixed in later patches.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 579153325158d944be544ced96c6218e7d48802a
Author: Kevin Wolf <kwolf at redhat.com>
Date: Wed Apr 14 15:24:50 2010 +0200
block: Avoid forward declaration of bdrv_open_common
Move bdrv_open_common so it's defined before its callers and remove the forward
declaration.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit b6ce07aa83bdee3cfd2610f270a0ce304e78df95
Author: Kevin Wolf <kwolf at redhat.com>
Date: Mon Apr 12 16:37:13 2010 +0200
block: Split bdrv_open
bdrv_open contains quite some code that is only useful for opening images (as
opposed to opening files by a protocol), for example snapshots.
This patch splits the code so that we have bdrv_open_file() for files (uses
protocols), bdrv_open() for images (uses format drivers) and bdrv_open_common()
for the code common for opening both images and files.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 84a12e6648444f517055138a7d7f25a22d7e1029
Author: Christoph Hellwig <hch at lst.de>
Date: Wed Apr 7 22:30:24 2010 +0200
block: separate raw images from the file protocol
We're running into various problems because the "raw" file access, which
is used internally by the various image formats is entangled with the
"raw" image format, which maps the VM view 1:1 to a file system.
This patch renames the raw file backends to the file protocol which
is treated like other protocols (e.g. nbd and http) and adds a new
"raw" image format which is just a wrapper around calls to the underlying
protocol.
The patch is surprisingly simple, besides changing the probing logical
in block.c to only look for image formats when using bdrv_open and
renaming of the old raw protocols to file there's almost nothing in there.
For creating images, a new bdrv_create_file is introduced which guesses the
protocol to use. This allows using qemu-img create -f raw (or just using the
default) for both files and host devices. Converting the other format drivers
to use this function to create their images is left for later patches.
The only issues still open are in the handling of the host devices.
Firstly in current qemu we can specifiy the host* format names
on various command line acceping images, but the new code can't
do that without adding some translation. Second the layering breaks
the no_zero_init flag in the BlockDriver used by qemu-img. I'm not
happy how this is done per-driver instead of per-state so I'll
prepare a separate patch to clean this up.
There's some more cleanup opportunity after this patch, e.g. using
separate lists and registration functions for image formats vs
protocols and maybe even host drivers, but this can be done at a
later stage.
Also there's a check for protocol in bdrv_open for the BDRV_O_SNAPSHOT
case that I don't quite understand, but which I fear won't work as
expected - possibly even before this patch.
Note that this patch requires various recent block patches from Kevin
and me, which should all be in his block queue.
Signed-off-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit ace22f6917849de28d8ba96b7426a0ea64f95369
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun May 2 18:38:10 2010 +0000
Fix missing '|' in '|=', spotted by clang analyzer
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit f75ca1ae205f24dae296c82d534c37746f87232f
Author: Thomas Monjalon <thomas at monjalon.net>
Date: Wed Apr 28 14:42:01 2010 +0200
fix old typos in help header
1) Qemu is not only a PC emulator.
2) "image image" has already been changed to "disk image" in qemu-doc.texi
Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 4d0e4ac703745e366d15ea5e174ae5e25c384461
Author: Stuart Brady <sdb at zubnet.me.uk>
Date: Tue Apr 27 22:23:35 2010 +0100
Clean up definition of MAX_OPC_PARAM
MAX_OPC_PARAM is intended to refer to the maximum number of entries used
in gen_opparam_buf[] for any single helper call. It is currently defined
as 10, but for 32-bit archs, the correct value (with a maximum for four
helper arguments) is 14, and for 64-bit archs, only 9 entries are needed.
tcg_gen_callN() fills four entries with the function address, flags,
number of args, etc. and on 32-bit archs uses a further two entries per
argument (with a maximum of four helper arguments), plus two more for the
return value. On 64-bit archs, only half as many entries are used for the
args and the return value.
In reality, TBs tend not to consist purely of helper calls exceeding the
stated 10 gen_opparam_buf[] entries, so this would never actually be a
problem on 32-bit archs, but the definition is still rather confusing.
Signed-off-by: Stuart Brady <sdb at zubnet.me.uk>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 50a480946b980c2000fc3b13bda174d57b45fbdd
Author: Igor V. Kovalenko <igor.v.kovalenko at gmail.com>
Date: Fri Apr 23 01:54:50 2010 +0400
cmd646: fix abort due to changed opaque pointer for ioport read
We cannot install different opaque pointer for read and write
of the same i/o address.
- handle zero address in bmdma_writeb_common and install
the same opaque pointer for both read and write access.
Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko at gmail.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 70ae65f5d91462e1905a53236179fde21cda3a2f
Author: Igor V. Kovalenko <igor.v.kovalenko at gmail.com>
Date: Fri Apr 23 01:54:45 2010 +0400
cmd646: pass pci_dev as it needs it
Instead of doing tricks to get the pci_dev, just pass it in the 1st
place. Patch is a bit longer that reverting the pci_dev field, but it
states more clearly (IMHO) what we are doing.
It also fixes the bm test, now that you told me that ->unit is not
always valid.
Signed-off-by: Juan Quintela <quintela at redhat.com>
Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko at gmail.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 8369e01ce418edb26a6e1f65406cac650563b3da
Author: Marcelo Tosatti <mtosatti at redhat.com>
Date: Fri Apr 23 14:04:14 2010 -0300
kvm: port qemu-kvm's bitmap scanning
Which is significantly faster.
Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com>
commit 213acd2ec24f86cdbfe3391c8776987fd6d5e373
Author: Marcelo Tosatti <mtosatti at redhat.com>
Date: Fri Apr 23 14:04:13 2010 -0300
introduce leul_to_cpu
To be used by next patch.
Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com>
commit cce83b7d625d71b8708c869403d1b8781af6f9b4
Author: Marcelo Tosatti <mtosatti at redhat.com>
Date: Fri Apr 23 14:04:11 2010 -0300
vga: fix typo in length passed to kvm_log_stop
Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com>
commit 9ed7b059ef776a3921cfd085e891f45076922542
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:11 2010 +0530
virtio-serial: Implement flow control for individual ports
Individual ports can now signal to the virtio-serial core to stop
sending data if the ports cannot immediately handle new data. When a
port later unthrottles, any data queued up in the virtqueue are sent to
the port.
Disable throttling once a port is closed (and we discard all the
unconsumed buffers in the vq).
The guest kernel can reclaim the buffers when it receives the port close
event or when a port is being removed. Ensure we free up the buffers
before we send out any events to the guest.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit a69c76008597ccdffae7a933686ab856ca85e87c
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:10 2010 +0530
virtio-serial: Discard data that guest sends us when ports aren't connected
Before the earlier patch, we relied on incorrect virtio api usage to
signal to the guest that a particular buffer wasn't consumed by the
host.
After fixing that, we now just discard the data the guest sends us while
a host port is disconnected or doesn't have a handler registered for
consuming data.
This commit really doesn't change anything from the current behaviour,
just makes the code slightly better by spinning off data handling to
ports in another function.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 1e4476aa03b70e78b0dbc21cebd6e9f9c6835067
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:09 2010 +0530
virtio-serial: Apps should consume all data that guest sends out / Fix virtio api abuse
We cannot indicate to the guest how much data was consumed by an app for
out_bufs. So we just have to assume the apps will consume all the data
that are handed over to them.
Fix the virtio api abuse in control_out() and handle_output().
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit e85ba9b2dce43d706e21135fc1bf21a30601c2cf
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:08 2010 +0530
virtio-serial: Handle scatter/gather input from the guest
Current guests don't send more than one iov but it can change later.
Ensure we handle that case.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
CC: Avi Kivity <avi at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit e61da14d60ba1cceacad8396adcb9662c7f690af
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:07 2010 +0530
virtio-serial: Handle scatter-gather buffers for control messages
Current control messages are small enough to not be split into multiple
buffers but we could run into such a situation in the future or a
malicious guest could cause such a situation.
So handle the entire iov request for control messages.
Also ensure the size of the control request is >= what we expect
otherwise we risk accessing memory that we don't own.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
CC: Avi Kivity <avi at redhat.com>
Reported-by: Avi Kivity <avi at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit fa6111f215736e44f0ac4fc50947e6c407588c28
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:06 2010 +0530
iov: Add iov_to_buf and iov_size helpers
iov_to_buf() puts the buffer contents in the iov in a linearized buffer.
iov_size() gets the length of the contents in the iov.
The iov_to_buf() function is the memcpy_to_iovec() function that was
used in virtio-ballon.c.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit e4d5639dbb6181ebbfdb554f2594721b2d63882b
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:05 2010 +0530
iov: Introduce a new file for helpers around iovs, add iov_from_buf()
The virtio-net code uses iov_fill() which fills an iov from a linear
buffer. The virtio-serial-bus code does something similar in an
open-coded function.
Create a new iov.c file that has iov_from_buf().
Convert virtio-net and virtio-serial-bus over to use this functionality.
virtio-net used ints to hold sizes, the new function is going to use
size_t types.
Later commits will add the opposite functionality -- going from an iov
to a linear buffer.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 3ecb45f893d09a97b8f24399b5e40808a708261f
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:04 2010 +0530
virtio-serial: Send out guest data to ports only if port is opened
Data should be written only when ports are open.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 4048c7c321d3029e8c41863a9f54dc39054c57ca
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:03 2010 +0530
virtio-serial: Propagate errors in initialising ports / devices in guest
If adding of ports or devices in the guest fails we can send out a QMP
event so that management software can deal with it.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 71c092e92b45e7ebc762c8736089c074097548d3
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:02 2010 +0530
virtio-serial: Update copyright year to 2010
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit e30f328c7429d4e891ce6da26af95c607f392739
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:01 2010 +0530
virtio-serial: Remove redundant check for 0-sized write request
The check for a 0-sized write request to a guest port is not necessary;
the while loop below won't be executed in this case and all will be
fine.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 306eb457fd057b7d0185145530a98f236b1c9aa4
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:04:00 2010 +0530
virtio-serial: whitespace: match surrounding code
The virtio-serial code doesn't mix declarations and definitions, so
separate them out on different lines.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 055b889f942b063bd1901a316b34017f2b699b12
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:03:59 2010 +0530
virtio-serial: Use control messages to notify guest of new ports
Allow the port 'id's to be set by a user on the command line. This is
needed by management apps that will want a stable port numbering scheme
for hot-plug/unplug and migration.
Since the port numbers are shared with the guest (to identify ports in
control messages), we just send a control message to the guest
indicating addition of new ports (hot-plug) or notifying the guest of
the available ports when the guest sends us a DEVICE_READY control
message.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 31abe21f4f026171128e6fbafb40062ae1872bd5
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:03:58 2010 +0530
virtio-serial: save/load: Send target host connection status if different
If the host connection to a port is closed on the destination machine
after migration, whereas the connection was open on the source, the
guest has to be informed of that.
Similar for a host connection open on the destination.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 16af2e3c35990cb7aceb37ffe5827a28fd4614d0
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:03:57 2010 +0530
virtio-serial: save/load: Ensure we have hot-plugged ports instantiated
If some ports that were hot-plugged on the source are not available on
the destination, fail migration instead of trying to deref a NULL
pointer.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Reported-by: Juan Quintela <quintela at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit 295587f747c7747e37208540a7a7f4d13a6ba4de
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:03:56 2010 +0530
virtio-serial: save/load: Ensure nr_ports on src and dest are same.
The number of ports on the source as well as the destination machines
should match. If they don't, it means some ports that got hotplugged on
the source aren't instantiated on the destination. Or that ports that
were hot-unplugged on the source are created on the destination.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Reported-by: Juan Quintela <quintela at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit e245795b50e97250ee63f86580457cf35f29f3ca
Author: Amit Shah <amit.shah at redhat.com>
Date: Tue Apr 27 18:03:55 2010 +0530
virtio-serial: save/load: Ensure target has enough ports
The target could be started with max_nr_ports for a virtio-serial device
lesser than what was available on the source machine. Fail the migration
in such a case.
Signed-off-by: Amit Shah <amit.shah at redhat.com>
Reported-by: Juan Quintela <quintela at redhat.com>
Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>
commit aacf4563878cac2afbbdc9818d810d2a3b075c6a
Author: Thomas Monjalon <thomas at monjalon.net>
Date: Tue Apr 27 15:27:09 2010 +0200
microblaze: fix custom fprintf
Using GCC-4.2.4-1ubuntu4, there is a warning:
microblaze-dis.c:792: warning: unused variable 'fprintf'
Indeed, fprintf() is shadowed by a custom redefinition but is not used because
of FORTIFY_SOURCE option which replace calls to fprintf() by fprintf_chk().
So, fprintf refers to the libc implementation instead of the qemu one.
It's a bug.
It is fixed by renaming the variable to something different of "fprintf".
It prevents from hazardous shadowing.
Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 14a6063a91083c9cbe1bc502ee58fc7ca146bc1a
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Apr 12 16:19:26 2010 -0700
Implement cpu_get_real_ticks for Alpha.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 18f8e2c08bbd0dd8d32a3a536787076b8b958a4b
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Apr 12 16:18:43 2010 -0700
target-alpha: Implement RPCC.
A minimal implementation that more or less corresponds to the
user-level version used by target-i386. More hoops will want
to be jumped through when alpha gets system-level emulation.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 6910b8f66a9ad0c2c2052b4be884e11b76049718
Author: Richard Henderson <rth at twiddle.net>
Date: Wed Apr 7 15:42:26 2010 -0700
target-alpha: Fix load-locked/store-conditional.
Use an exception plus start_exclusive to implement the compare-and-swap.
This follows the example set by the MIPS and PPC ports.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 8aa3fa2038d9d0a7d69acdac505d990acc5eafc8
Author: Richard Henderson <rth at twiddle.net>
Date: Wed Apr 7 13:32:50 2010 -0700
target-alpha: Indicate NORETURN status when raising exception.
When (indirectly) calling raise_exception, don't emit cleanup
code at the end of the TB, as it is unused.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit a4b388ff51c2feb5eca563feae9bfc5fc1c5c85c
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Apr 12 16:17:22 2010 -0700
target-alpha: Enable NPTL.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 49563a727494197ad87936bfd07841878878b650
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Mar 29 10:48:14 2010 -0700
target-alpha: Update commentary for opcode 0x1A.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 4af7037462c03b1a7d5cf8ecd423c85bf221acaf
Author: Richard Henderson <rth at twiddle.net>
Date: Tue Mar 16 15:10:49 2010 -0700
target-alpha: Emit goto_tb opcodes.
Use an ExitStatus enumeration instead of magic numbers as the return
value from translate_one. Emit goto_tb opcodes when ending a TB via
a direct branch.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 593f17e5f2125a7186a4a1917cb8603ffb636d48
Author: Richard Henderson <rth at twiddle.net>
Date: Wed Apr 7 10:17:24 2010 -0700
target-alpha: Implement cvtlq inline.
It's a simple shift and mask sequence.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit ac316ca4b7b27c853c0d9d6b43abdbefc97297d6
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Apr 12 16:14:54 2010 -0700
target-alpha: Implement rs/rc properly.
This is a per-cpu flag; there's no need for a spinlock of any kind.
We were also failing to manipulate the flag with $31 as a target reg
and failing to clear the flag on execution of a return-from-interrupt
instruction.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit dc96be4b975d51f03d0b08e191fddf85b92c0267
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Apr 12 16:12:20 2010 -0700
target-alpha: Implement cpys{, n, e} inline.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit caa972256d793359fddc57a54506d7645b3bf9e2
Merge: 70ec48ef55e5a3d5ecef8599f3fbdfb87f0740dc e53f27b9d9df73461308618151fa6e6392aebd85
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Mon Apr 26 15:10:14 2010 -0500
Merge remote branch 'qmp/for-anthony' into staging
commit e53f27b9d9df73461308618151fa6e6392aebd85
Author: Paolo Bonzini <pbonzini at redhat.com>
Date: Fri Apr 16 17:25:23 2010 +0200
stash away SCM_RIGHTS fd until a getfd command arrives
If there is already a fd in s->msgfd before recvmsg it is
closed by parts that this patch does not touch. So, only
one descriptor can be "leaked" by attaching it to a command
other than getfd.
Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 97331287ed2c928af6b9f31728d29ef60c3b8cd8
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Tue Apr 6 16:55:54 2010 +0200
chardev: Document mux option
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 157b9319878e67f5c28b8cf39216d42f4b162586
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Tue Apr 6 16:55:53 2010 +0200
monitor: Reorder intialization to drop initial mux focus
So far a multiplexed monitor started disabled. Restore this property for
the new way of configuring by moving the monitor initialization before
all devices (the last one to attach to a char-mux will gain the focus).
Once we have a real use case for that, we may also consider assigning
the initial focus explicitly.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 140e065d72a2301b0b5f769be664e10ebe223888
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Tue Apr 6 16:55:52 2010 +0200
monitor: Cleanup ID assignment for compat switch
Canonicalize the ID assignment when creating monitor devices via the
legacy switch and use less easily colliding names.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 0e8d2b5575938b8876a3c4bb66ee13c5d306fb6d
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Tue Apr 6 18:55:54 2010 -0300
Monitor: Return before exiting with 'quit'
The 'quit' Monitor command (implemented by do_quit()) calls
exit() directly, this is problematic under QMP because QEMU
exits before having a chance to send the ok response.
Clients don't know if QEMU exited because of a problem or
because the 'quit' command has been executed.
This commit fixes that by moving the exit() call to the main
loop, so that do_quit() requests the system to quit, instead
of calling exit() directly.
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 70ec48ef55e5a3d5ecef8599f3fbdfb87f0740dc
Author: Richard Henderson <rth at twiddle.net>
Date: Sat Apr 10 22:22:28 2010 +0200
tcg-hppa: Remove automatically implemented opcodes.
Remove neg, ext8u, ext16u, as requested.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 2d097a83e223d3e06de5047e95eeadf1f919ac56
Author: Richard Henderson <rth at twiddle.net>
Date: Fri Apr 9 21:49:00 2010 +0200
tcg-hppa: Fix branch offset during retranslation.
Branch offsets should only be overwritten during relocation,
to support partial retranslation.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 739734cb5cf90c3e692d41b51fa095240b49ddd7
Author: Richard Henderson <rth at twiddle.net>
Date: Fri Apr 9 10:49:10 2010 -0700
tcg-hppa: Schedule the address masking after the TLB load.
Issue the tlb load as early as possible and perform the address
masking while the load is completing.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit f061b40e91b96d32e535cc81362904c685483506
Author: Richard Henderson <rth at twiddle.net>
Date: Fri Apr 9 10:48:02 2010 -0700
tcg-hppa: Fix softmmu loads and stores.
Along the tlb hit path, we were modifying the variables holding the input
register numbers, which lead to incorrect expansion of the tlb miss path.
Fix this by extracting the tlb hit path to separate functions with their
own local variables. This also makes the difference between softmmu and
user-only easier to read.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 884d348b7bd4c6f1c1993dafd2e89ac31fe4e543
Author: Richard Henderson <rth at twiddle.net>
Date: Fri Apr 9 10:46:40 2010 -0700
tcg-hppa: Fix GUEST_BASE initialization in prologue.
Load from the guest_base variable rather than embed a constant.
Always reserve TCG_GUEST_BASE_REG if guest base support enabled.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 0085bd5161190840ed810d771a63c8a66e7bc380
Author: Richard Henderson <rth at twiddle.net>
Date: Fri Apr 9 10:45:49 2010 -0700
tcg-hppa: Constrain immediate inputs to and_i32, or_i32, andc_i32.
Define "M" constraint for and_mask_p and "O" constraint for or_mask_p.
Assume that inputs are correct in tcg_out_ori and tcg_out_andi.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit ed18c5ce1d2aabdaa0a138463789b9fe812bb0e0
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Apr 26 10:27:22 2010 -0700
linux-user: Fix sparc32plus stat64 syscalls.
Check TARGET_ABI_BITS, not TARGET_LONG_BITS, when deciding
whether or not the guest needs special 64-bit stat translation.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 060718c19423fd1b24fa3a232bf99c5c97a7d61b
Author: Richard Henderson <rth at twiddle.net>
Date: Mon Apr 26 10:17:24 2010 -0700
target-sparc: Fix -singlestep.
Single-stepping was not properly updating npc, resulting in some
instructions being executed twice. In addition, we were emitting
dead code at the end of the TB.
Fix both by teaching gen_goto_tb to avoid goto_tb for single-step
and removing the special-case code in gen_intermediate_code_internal.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 6164e6d6e86e8f3f0b5ff7ae08b677026cb291c3
Author: Marcelo Tosatti <mtosatti at redhat.com>
Date: Tue Mar 23 13:37:13 2010 -0300
kvm_init_vcpu requires global lock held
Since it accesses data protected by the lock.
Signed-off-by: Avi Kivity <avi at redhat.com>
commit 204204308b011d5fe494970255b318ec444d1d45
Author: Sheng Yang <sheng at linux.intel.com>
Date: Tue Mar 23 13:37:12 2010 -0300
kvm: allow qemu to set EPT identity mapping address
If we use larger BIOS image than current 256KB, we would need move reserved
TSS and EPT identity mapping pages. Currently TSS support this, but not
EPT.
Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com>
Signed-off-by: Avi Kivity <avi at redhat.com>
commit 7c80eef899ff0feb1ab6730d4dd3bc3aee046093
Author: Marcelo Tosatti <mtosatti at redhat.com>
Date: Tue Mar 23 13:37:11 2010 -0300
kvm: handle internal error
Port qemu-kvm's KVM_EXIT_INTERNAL_ERROR handling to upstream.
Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com>
Signed-off-by: Avi Kivity <avi at redhat.com>
commit b5e5a934174ade5dcfc98a41f21f8a6c4816dd54
Author: Marcelo Tosatti <mtosatti at redhat.com>
Date: Tue Mar 23 13:37:10 2010 -0300
target-i386: print EFER in cpu_dump_state
Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com>
Signed-off-by: Avi Kivity <avi at redhat.com>
commit ff44f1a3737bfda3cac294b8e92d8ec5ddf3abf5
Author: Jan Kiszka <jan.kiszka at siemens.com>
Date: Fri Mar 12 15:20:49 2010 +0100
KVM: x86: Add debug register saving and restoring
Make use of the new KVM_GET/SET_DEBUGREGS to save/restore the x86 debug
registers.
Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti at redhat.com>
commit 04f8c053cca9c329eebb761f3a1ffef3d349b84c
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Tue Apr 6 16:39:42 2010 -0300
QMP: Check "arguments" member's type
Otherwise the following input crashes QEMU:
{ "execute": "migrate", "arguments": "tcp:0:4446" }
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit abaf2f52716625d4b1e29204cab644ed656504cf
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Wed Apr 7 14:53:49 2010 -0300
QError: Improve QERR_QMP_BAD_INPUT_OBJECT desc
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 88f7db846264223f6059ec329e7b7a77026ad475
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Wed Apr 7 14:49:37 2010 -0300
QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER
The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only
for two problems: the input is not an object or the "execute"
key is missing.
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 7dfb61238a472acf6fb48d9a444564b9b99a4b56
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Wed Apr 7 14:46:33 2010 -0300
QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit a303f9e37b87ced34e966dc2c0b7f86bc5e74035
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 20:42:43 2010 +0000
sh4: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 9fad3eb7fa27616846b1ef477947771337bbe0fd
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 20:33:43 2010 +0000
ppc: add missing 'break', spotted by clang analyzer
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 05f92404cd8e0fa3204182350d19c74451f9c4b7
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 20:32:49 2010 +0000
ppc: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit b2c58871c9fd3a6fe7f670b97af7708809477721
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 20:31:42 2010 +0000
alpha: add missing 'break', spotted by clang analyzer
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit f88fe4e3706ca59af06fdd0e2d696f720328db56
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 20:30:17 2010 +0000
alpha: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 183aa45407e7b665d88842f8e288f6bbcac15e22
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 20:00:33 2010 +0000
microblaze: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 37ca43a141a9cefd6733a6e9281690cd1a1dc419
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 19:50:51 2010 +0000
m68k: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 0d84be5bd0df34c2663b38d6efd7d850d15f2eb0
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 19:46:46 2010 +0000
cris: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 22ed1d34789b184aaaa28c1e4620ce4467744cec
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 19:31:06 2010 +0000
arm: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 7f5b7d3e2c19c0aa52dcac0a10d473c7fd142450
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 18:58:25 2010 +0000
x86: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 9678d9501bc5f2e6e06170013dec8667057c3b62
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 18:35:52 2010 +0000
Remove dead assignments in various common files, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit d4c4e6fdc7f5077fba3446f6e650eb94d07a0be5
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 18:23:04 2010 +0000
usb: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 7300c07991e05e66e04528aa1c72e31c127a79cd
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 18:20:28 2010 +0000
bt: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 2cc2026063a7500670a76edd5ece59936ceec441
Author: Richard Henderson <rth at twiddle.net>
Date: Sun Apr 25 11:01:25 2010 -0700
linux-user: Fix Sparc64 syscall returns.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 88bf79500b7659aa7978b445393479d76e9c0c9e
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 25 15:27:14 2010 +0000
Fix dead initialization, spotted by clang analyzer
Fix clang warnings:
/src/qemu/block/vvfat.c:1102:9: warning: Value stored to 'index3' during its initialization is never read
int index3=index1+1;
/src/qemu/cmd.c:290:15: warning: Value stored to 'p' during its initialization is never read
char *p = result;
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit f64052478e3828393aea4248da4047b86d48f83f
Author: Richard Henderson <rth at twiddle.net>
Date: Thu Apr 22 16:47:31 2010 -0700
Remove IO_MEM_SUBWIDTH.
Greatly simplify the subpage implementation by not supporting
multiple devices at the same address at different widths. We
don't need full copies of mem_read/mem_write/opaque for each
address, only a single index back into the main io_mem_* arrays.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 6495a044575c01aee960c54e8a138ac51ed8a835
Author: Richard Henderson <rth at twiddle.net>
Date: Thu Apr 22 17:24:58 2010 -0700
linux-user: Remove ELFLOAD32.
The ABI-specific types used by linux_binprm and image_info
are different after forcing TARGET_ABI32 on. Which means
that the parameters that load_elf_binary_multi sees are not
those that loader_exec passed. This is inherently broken
and is more trouble than it's worth fixing.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit e23886a91d954aac08b8b1dd0ff08ce4dbb842be
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Sun Apr 25 05:46:22 2010 +0200
tcg/arm: fix condition in zero/sign extension functions
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 20d97356c9df6d68fbd37d6334fdb7063f24eab6
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Fri Apr 23 20:19:47 2010 +0000
Fix OpenBSD build
GCC 3.3.5 generates warnings for static forward declarations of data, so
rearrange code to use static forward declarations of functions instead.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit c4162574c46307511f0fbd142164a45db98e2a23
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Fri Apr 23 19:22:22 2010 +0000
m68k: fix if statement with empty body, spotted by clang
Fix clang error:
CC m68k-softmmu/helper.o
/src/qemu/target-m68k/helper.c:773:33: error: if statement has empty body [-Wempty-body]
else if (val & (1ull << 47));
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 67774a0444d42311c89898dd22240b5794a7f403
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Fri Apr 23 19:22:17 2010 +0000
m68k-dis: fix unused return value, spotted by clang
Fix clang errors like:
CC libdis/m68k-dis.o
/src/qemu/m68k-dis.c:1796:7: error: expression result unused [-Wunused-value]
FETCH_DATA (info, p);
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 4aa720f717570c9a4cb26b5f8528461f1be0996b
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Fri Apr 23 19:22:12 2010 +0000
Fix harmless if statement with empty body, spotted by clang
This clang error is harmless but worth fixing:
CC libhw32/rc4030.o
/src/qemu/hw/rc4030.c:244:66: error: if statement has empty body [-Wempty-body]
DPRINTF("read 0x%02x at " TARGET_FMT_plx "\n", val, addr);
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 43d5438997c49896879f5522b0dfa98f0052888d
Merge: 1e1ea48d42e011b9bdd0d689d184e7cac4617b66 41db525e9c6e4c98d6e41c403c7dc704ce0e77aa
Author: Anthony Liguori <aliguori at us.ibm.com>
Date: Fri Apr 23 13:48:33 2010 -0500
Merge remote branch 'origin/master' into staging
commit 41db525e9c6e4c98d6e41c403c7dc704ce0e77aa
Author: Richard Henderson <rth at twiddle.net>
Date: Thu Apr 22 22:56:42 2010 -0700
target-sparc: Fix address masking in ldqf and stqf.
Use address_mask on both addr and addr+8 in both these routines,
rather than explicit masking with 0xffffffff.
Reformulate address_mask to return a result, rather than masking
a pass-by-reference argument.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 1e1ea48d42e011b9bdd0d689d184e7cac4617b66
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Wed Apr 21 20:35:45 2010 +0100
block: Free iovec arrays allocated by multiwrite_merge()
A new iovec array is allocated when creating a merged write request.
This patch ensures that the iovec array is deleted in addition to its
qiov owner.
Reported-by: Leszek Urbanski <tygrys at moo.pl>
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit d4c146f0da2ace38b1a0e9ba42374901198909cf
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Thu Apr 15 14:11:35 2010 +0100
qcow2: Use QLIST_FOREACH_SAFE macro
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 2be5064953540d5451480375519389f104eb7909
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Wed Apr 14 12:13:36 2010 +0100
linux-aio: Fix typo in read() EINTR check
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit adfe078e4b658c5406be089980c5b9034bae42a4
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Tue Apr 13 10:29:35 2010 +0100
qemu-img: Fix BRDV_O_FLAGS typo
It should be BDRV_O_FLAGS instead of BRDV_O_FLAGS.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit f163d0736ce0ccf50128254409a6cfc0258fa943
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Tue Apr 13 10:29:34 2010 +0100
qemu-img: Eliminate bdrv_new_open() code duplication
Several commands have code to create a BlockDriverState and open a file.
The bdrv_new_open() function can be used to perform these steps. This
patch converts the qemu-img commands to actually use bdrv_new_open().
Replaced the bdrv_new_open() 'readonly' argument with bdrv_open()-style
flags to support generic flags like BDRV_O_NO_BACKING.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 8a22f02a88b5c37bdbd48fc18ff6e572a8ffdfe2
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Tue Apr 13 10:29:33 2010 +0100
block: Convert first_drv to QLIST
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 85de0ba5e9dc8d318cd2c34b7a8d368946160a24
Author: Kevin Wolf <kwolf at redhat.com>
Date: Tue Apr 13 12:41:35 2010 +0200
block.h: bdrv_create2 doesn't exist any more
The bdrv_create2 implementation has disappeared long ago. Remove its
prototype from the header file, too.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 3cc128bb1e2f41b64ca82d8252fb678a60611de0
Author: Bruce Rogers <brogers at novell.com>
Date: Mon Apr 12 06:56:00 2010 -0600
Remove un-needed code
The bdrv_set_geometry_hint call below is not needed - it's just setting
what was just read.
Signed-off-by: Bruce Rogers <brogers at novell.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 1b7bdbc13ccbec154c0ef768f70c9eb604befb8c
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Sat Apr 10 07:02:42 2010 +0100
block: Convert bdrv_first to QTAILQ
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit b66460e4e938910b0e5495e6d3d7b2d5b3cf9c99
Author: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Date: Fri Apr 9 15:22:13 2010 +0100
block: Do not export bdrv_first
The bdrv_first linked list of BlockDriverStates is currently extern so
that block migration can iterate the list. However, since there is
already a bdrv_iterate() function there is no need to expose bdrv_first.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 763b6084baaf7d4e8b93f8b74f23a37b2fdb4eb4
Author: Christoph Hellwig <hch at lst.de>
Date: Tue Apr 6 19:12:04 2010 +0200
cleanup block driver option handling in vl.c
Assign directly to the bdrv_flags variable instead of using
magic numbers before translating to the BDRV_O_* options.
Signed-off-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit c46e116723803012853690f7938d7f66b92489db
Author: Kevin Wolf <kwolf at redhat.com>
Date: Tue Mar 23 17:41:24 2010 +0100
qcow2: Return 0/-errno in l2_allocate
Returning NULL on error doesn't allow distinguishing between different errors.
Change the interface to return an integer for -errno.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit f7defcb62792eff05fa8a7ffec6a927a88087b83
Author: Kevin Wolf <kwolf at redhat.com>
Date: Tue Mar 23 17:28:22 2010 +0100
qcow2: Return 0/-errno in write_l1_entry
Change write_l1_entry to return the real error code instead of -1.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit c835d00fc8d6c23af7e9182981ef7a07f1c6d12c
Author: Kevin Wolf <kwolf at redhat.com>
Date: Tue Mar 23 12:53:47 2010 +0100
qcow2: Fix error return code in qcow2_alloc_cluster_link_l2
Fix qcow2_alloc_cluster_link_l2 to return the real error code like it does in
all other error cases.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 79a31189d4e3d226c6c700d630476ec63bbc19a2
Author: Kevin Wolf <kwolf at redhat.com>
Date: Tue Mar 23 12:49:17 2010 +0100
qcow2: Return 0/-errno in write_l2_entries
Change write_l2_entries to return the real error code instead of -1.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 50779cc264aa1abd75aa5afa34740d4fd8481f1d
Author: Christoph Hellwig <hch at lst.de>
Date: Tue Apr 6 19:13:44 2010 +0200
block: split raw_getlength
Split up the raw_getlength into separate generic, solaris and BSD
versions to reduce the ifdef maze a bit. The BSD variant still
is a complete maze, but to clean it up properly we'd need some
people using the BSD variants to figure out what code is used
for what variant.
Signed-off-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 6db956039db8a6333265d458be561dc1bc2b4481
Author: Christoph Hellwig <hch at lst.de>
Date: Mon Apr 5 16:53:57 2010 +0200
block: get rid of the BDRV_O_FILE flag
BDRV_O_FILE is only used to communicate between bdrv_file_open and bdrv_open.
It affects two things: first bdrv_open only searches for protocols using
find_protocol instead of all image formats and host drivers. We can easily
move that to the caller and pass the found driver to bdrv_open. Second
it is used to not force a read-write open of a snapshot file. But we never
use bdrv_file_open to open snapshots and this behaviour doesn't make sense
to start with.
qemu-io abused the BDRV_O_FILE for it's growable option, switch it to
using bdrv_file_open to make sure we only open files as growable were
we can actually support that.
This patch requires Kevin's "[PATCH] Replace calls of old bdrv_open" to
be applied first.
Signed-off-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit d6e9098e10e82feeddb824d7c3d0cf61aff96c29
Author: Kevin Wolf <kwolf at redhat.com>
Date: Wed Mar 31 14:40:27 2010 +0200
Replace calls of old bdrv_open
What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
callers of the old function are converted to the new one. In some places they
even know the right format, so they should have used bdrv_open2 from the
beginning.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 4768fa902c3860f2fe34403e6e1c83bfca6da034
Author: Kevin Wolf <kwolf at redhat.com>
Date: Fri Mar 26 17:37:20 2010 +0100
qcow2: Fix creation of large images
qcow_create2 assumes that the new image will only need one cluster for its
refcount table initially. Obviously that's not true any more when the image is
big enough (exact value depends on the cluster size).
This patch calculates the refcount table size dynamically.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 8252278afb4b646a5a21cf8c30bb0a0066825078
Author: Kevin Wolf <kwolf at redhat.com>
Date: Mon Mar 15 17:38:05 2010 +0100
qcow2: Trigger blkdebug events
This adds blkdebug events to qcow2 to allow injecting I/O errors in specific
places.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 8b9b0cc2fd1b866c0ce6c7f7385d840aad8b4c2c
Author: Kevin Wolf <kwolf at redhat.com>
Date: Mon Mar 15 17:27:00 2010 +0100
blkdebug: Add events and rules
Block drivers can trigger a blkdebug event whenever they reach a place where it
could be useful to inject an error for testing/debugging purposes.
Rules are read from a blkdebug config file and describe which action is taken
when an event is triggered. For now this is only injecting an error (with a few
options) or changing the state (which is an integer). Rules can be declared to
be active only in a specific state; this way later rules can distiguish on
which path we came to trigger their event.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 25920d6ad61b078a69b6ba401d4d6cd46ce83804
Author: Kevin Wolf <kwolf at redhat.com>
Date: Mon Mar 15 17:01:24 2010 +0100
Make qemu-config available for tools
To be able to use config files for blkdebug, we need to make these functions
available in the tools. This involves moving two functions that can only be
built in the context of the emulator.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit b9f66d96950b7c10253f9f27b9109df5ff8aa611
Author: Kevin Wolf <kwolf at redhat.com>
Date: Fri Feb 19 16:24:35 2010 +0100
blkdebug: Inject errors
Add a mechanism to inject errors instead of passing requests on. With no
further patches applied, you can use it by setting inject_errno in gdb.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 6a1437273ca3685f4bc8065fd921834d9b5608e1
Author: Kevin Wolf <kwolf at redhat.com>
Date: Thu Feb 18 17:48:12 2010 +0100
blkdebug: Basic request passthrough
This isn't doing anything interesting. It creates the blkdebug block driver as
a protocol which just passes everything through to raw.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 490b648e5b8987d4d497c222e0941a8b129a5eb6
Author: Kevin Wolf <kwolf at redhat.com>
Date: Fri Mar 5 18:21:56 2010 +0100
qemu-config: Make qemu_config_parse more generic
qemu_config_parse gets the option groups as a parameter now instead of
hardcoding the VM configuration groups. This way it can be used for other
configurations, too.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit dcfb0939bd7042c9d2622181263c01d78531f272
Author: Kevin Wolf <kwolf at redhat.com>
Date: Fri Mar 5 17:25:55 2010 +0100
qemu-config: qemu_read_config_file() reads the normal config file
Introduce a new function qemu_read_config_file which reads the VM configuration
from a config file. Unlike qemu_config_parse it doesn't take a open file but a
filename and reduces code duplication as a side effect.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
commit 6c557ab975fc8e5edb4167a241266c7c4657054a
Author: Serge Ziryukin <ftrvxmtrx at gmail.com>
Date: Thu Apr 22 14:14:24 2010 +0300
audio/sdlaudio: remove unused variable
Remove unused 'shift' variable spotted by clang.
Also clean up aud_to_sdlfmt which used to get the value
of shift.
Signed-off-by: Serge Ziryukin <ftrvxmtrx at gmail.com>
Signed-off-by: malc <av1474 at comtv.ru>
commit a6e4b143883b8504f6793966c36093354b38a889
Author: Andrzej Zaborowski <balrog at zabor.org>
Date: Thu Apr 22 03:55:46 2010 +0200
bt-sdp: Fix an excessive ; and assignment of the wrong variable
Problem-spotted-by: Blue Swirl <blauwirbel at gmail.com>
Signed-off-by: Andrew Zaborowski <balrogg at gmail.com>
commit 7b1df88f284f462ecb236931ad863a815f243195
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Thu Apr 22 03:41:24 2010 +0200
bt-l2cap: fix if statement with empty body, spotted by clang
Fix clang error:
CC bt-l2cap.o
/src/qemu/hw/bt-l2cap.c:1000:41: error: if statement has empty body
[-Wempty-body]
/* TODO: Signal an error? */;
This means that l2cap_sframe_in() may now get called.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
Signed-off-by: Andrew Zaborowski <balrogg at gmail.com>
commit 8bb414d2aac3b41695b528f21b7e285ebdb225e4
Author: malc <av1474 at comtv.ru>
Date: Wed Apr 21 15:40:23 2010 +0400
audio/alsa: Avoid snd_pcm_format_t vs audfmt_e mixup
Spotted by Serge Ziryukin and based on his patch, thanks.
Signed-off-by: malc <av1474 at comtv.ru>
commit 470e63633f371611c1a03ffe4229eadccfbe013b
Author: Isaku Yamahata <yamahata at valinux.co.jp>
Date: Mon Apr 12 11:58:59 2010 +0900
pci: fix pci_find_bus().
When looking down child bus, it should look parent bridge's
bus number, not child bus's.
Optimized tail recursion and style fix.
Cc: Blue Swirl <blauwirbel at gmail.com>
Cc: "Michael S. Tsirkin" <mst at redhat.com>
Signed-off-by: Isaku Yamahata <yamahata at valinux.co.jp>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit ab07b980c442b4f94f8fe9c236d7702c19bf2c74
Author: Juha Riihimäki <juha.riihimaki at nokia.com>
Date: Tue Apr 13 09:16:55 2010 +0300
slirp: fix structure initialization in tcp_listen()
A data structure of type sockaddr_in is allocated from stack but not
properly initialized. This may lead to a failure in the bind() call
later on. Fixed by filling the contents of the structure with zeroes
before using it.
Signed-off-by: Juha Riihimäki <juha.riihimaki at nokia.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit d3538b45ea88e82d1b01959b4ca55d3696b71cb2
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Mon Apr 19 19:47:49 2010 +0000
Compile event_notifier only once
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 04c9a0cbc2bf496889cef6da2d61bf00ef190a4f
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Mon Apr 19 19:46:13 2010 +0000
Compile vl.c once
Since kvm.h can be used in files compiled once,
we can partially revert
b33612d03540fda7fa67485f1c20395beb7a2bf0.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 98c8573eb37bf5d7bb0c07225985a78537c73101
Author: Paolo Bonzini <pbonzini at redhat.com>
Date: Mon Apr 19 18:59:30 2010 +0000
provide a stub version of kvm-all.c if !CONFIG_KVM
This allows limited use of kvm functions (which will return ENOSYS)
even in once-compiled modules. The patch also improves a bit the error
messages for KVM initialization.
Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
[blauwirbel at gmail.com: fixed Win32 build]
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit c66b5c2cb6bf5ab9869bf0739ff3cdf143ab778c
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: don't try to load constants using pc
There is statistically almost 0 chances to use this code, so
remove it.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 914ccf51b07af860021863e0f8e46eac9ffbcb68
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: optimize register allocation order
The beginning of the register allocation order list on the TCG arm
target matches the list of clobbered registers. This means that when an
helper is called, there is almost always clobbered registers that have
to be spilled.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit bf5675efe33888fe058210be98259a34faf4d4e5
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: fix argument alignment in qemu_st64
64-bit arguments should be aligned on an even register as specified
by the "Procedure Call Standard for the ARM Architecture".
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 2633a2d015b0ba57432f1e11970cc080eb5119a3
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: remove useless register tests in qemu_ld/st
addr_reg, data_reg and data_reg2 can't be register r0 or r1 du to the
constraints. Don't check if they equals these registers.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 67dcab7327bb7fe02912734bf774ca44d84b41a1
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: bswap arguments in qemu_ld/st if needed
On big endian targets, data arguments of qemu_ld/st ops have to be
byte swapped. Two temporary registers are needed for qemu_st to do
the bswap. r0 and r1 are used in system mode, do the same in user
mode, which implies reworking the constraints.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit e854b6d39c879bf36c1cf42f1dbfa0da89b06e75
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: use ext* ops in qemu_ld
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 7e0d95628d358dd3696ec69351e332347d80f0dd
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: remove conditional argument for qemu_ld/st
While it make sense to pass a conditional argument to tcg_out_*()
functions as the ARM architecture allows that, it doesn't make sense
for qemu_ld/st functions. These functions use comparison instructions
and conditional execution already, so it is not possible to use a
second level of conditional execution.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 244b1e81f6afc2ddc866a6dbad42ccafd10c246b
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: add bswap ops
Add an bswap16 and bswap32 ops, either using the rev and rev16
instructions on ARMv6+ or shifts and logical operations on previous
ARM versions. In both cases the result use less instructions than
the pure TCG version.
These ops are also needed by the qemu_ld/st functions.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 9517094f720097b51854ef458ffb1971720dddfa
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: add ext16u op
Add an ext16u op, either using the uxth instruction on ARMv6+ or two
shifts on previous ARM versions. In both cases the result use the same
number or less instructions than the pure TCG version.
Also move all sign extension code to separate functions, so that they
can be reused in other parts of the code.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 293579e55c40d78353ecd3e48d67f744ba579c12
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: add rotation ops
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 23401b58a4a47e964b838339f718b2993bd9345a
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: use the blx instruction when possible
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 8f7f749f216af458ea96573c4057f13023e3268d
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: sxtb and sxth are available starting with ARMv6
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit ac34fb5c5d46398ede6e16d4fd1fd26af8185335
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: add variables to define the allowed instructions set
Use a set of variables to define the allowed ARM instructions, depending
on the __ARM_ARCH_*__ GCC defines.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 2488b41bb2d03c96ffdd69a0c16b585e90697951
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: align 64-bit arguments in function calls
As specified by the "Procedure Call Standard for the ARM Architecture".
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit c8d80cef55522ca68618d5aa3153fd4b8f053573
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: replace integer values by registers enum
The TCG ARM backends uses integer values to refer to both immediate
values and register number. This makes the code difficult to read.
The patch below replaces all (if I haven't miss any ;-) integer values
representing register number by TCG_REG_* enum values.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit f694a27ed7281ce29f2b86235f79ef16ff759b7e
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: remove store signed functions
Store signed functions doesn't make sense, and are not used. Remove
them.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit e4a7d5e88c361040a64a0f298d666a273dc6db85
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: explicitely list clobbered/reserved regs
Instead of writing very compact code, declare all registers that are
clobbered or reserved one by one. This makes the code easier to read.
Also declare all the 16 registers to TCG, and mark pc as reserved.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 39221a82be8d224e935bdba10ce108a1a808a52f
Author: Aurelien Jarno <aurelien at aurel32.net>
Date: Fri Apr 9 20:52:48 2010 +0200
tcg/arm: remove SAVE_LR code
There is no need to save the LR register (r14) before a call to a
subroutine. According to the "Procedure Call Standard for the ARM
Architecture", it is the job of the callee to save this register.
Moreover, this register is already saved in the prologue/epilogue.
This patch removes the disabled SAVE_LR code, as there is no need to
reenable later.
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit d6fa4b77fb8f27ac84cf23fb1e15016673d98a47
Author: M. Mohan Kumar <mohan at in.ibm.com>
Date: Mon Apr 12 10:01:33 2010 +0530
Check for invalid initrd file
When qemu is invoked with an invalid initrd file, it crashes. Following
patch prints a error message and exits if an invalid initrd is
specified. Includes changes suggested by JV.
Signed-off-by: M. Mohan Kumar <mohan at in.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit f1dc58e07decfa21f6141d6c441008d4b8b83331
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Wed Mar 31 15:21:49 2010 -0300
Monitor: Convert do_screen_dump() to QObject
Trivial, as it never fails, doesn't have output nor return
any data.
Note that it's also available under QMP, as kvm-autotest
needs this.
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit db11571f090c5e72b5da5772fe3ba6557aacd572
Author: Luiz Capitulino <lcapitulino at redhat.com>
Date: Wed Mar 24 17:24:37 2010 -0300
QMP: Improve RTC_CHANGE event description
Some people might think that this event is emitted whenever the
time changes, be more specific.
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 908bb9497bcb5543930cc345326afff939a6ffa4
Author: Kevin Wolf <kwolf at redhat.com>
Date: Wed Mar 31 17:46:59 2010 +0200
virtio-blk: Fix use after free in error case
virtio_blk_req_complete frees the request, so we can't access it any more when
calling bdrv_mon_event. Use the pointer that was copied earlier.
Signed-off-by: Kevin Wolf <kwolf at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 5369e3c0b8997210a2558191d8451775f7643683
Author: Markus Armbruster <armbru at redhat.com>
Date: Fri Mar 26 09:07:11 2010 +0100
monitor: Convert do_set_link() to QObject, QError
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit c9b26a4cbe1e3ce71521b8a1ff0483f4cc4fa4bf
Author: Markus Armbruster <armbru at redhat.com>
Date: Fri Mar 26 09:07:10 2010 +0100
monitor: Use argument type 'b' for set_link
Second argument is now "on" or "off" instead of "up" or "down".
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 942cd1f2889dbc74db850218b270bc5b41656dfd
Author: Markus Armbruster <armbru at redhat.com>
Date: Fri Mar 26 09:07:09 2010 +0100
monitor: New argument type 'b'
This is a boolean value. Human monitor accepts "on" or "off".
Consistent with option parsing (see parse_option_bool()).
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit ee9545dad4004b92a93554a92cbb3e1b0e1c949d
Author: Markus Armbruster <armbru at redhat.com>
Date: Fri Mar 26 09:07:08 2010 +0100
monitor: Rename argument type 'b' to 'f'
To make 'b' available for boolean argument.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit ae82d3242d9db904f8ab81a5c7d796ae2eb46f04
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:40 2010 +0100
monitor: New commands netdev_add, netdev_del
Monitor commands to go with -netdev.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 5124eb5927d4d90adc5640e5d36a589bfadd1828
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:39 2010 +0100
error: New QERR_DEVICE_IN_USE
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 5294e2c774f120e10b44652ac143abda356f44eb
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:38 2010 +0100
error: Convert net_client_init() to QError
The conversion is shallow: client type init() methods aren't
converted. Converting them is a big job for relatively little
practical benefit, so leave it for later.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit db716e9c16737d2575143d88a73ed1dec8dec0fb
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:37 2010 +0100
error: Convert qemu_opts_validate() to QError
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit e17ba87c52fc7d4ccfd5074428ce19f1b876ba30
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:36 2010 +0100
error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit c389c43ee517fbfb8b18ebb520fb4c707e10646e
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:35 2010 +0100
error: Drop extra messages after qemu_opts_set() and qemu_opts_parse()
Both functions report errors nicely enough now, no need for additional
messages.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit c64f27d4f44192579087caa3ec4bd6552caef169
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:34 2010 +0100
error: Convert qemu_opts_set() to QError
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 985a3e52f0a21edb7b2564f6c103ffee1dc382f6
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:33 2010 +0100
error: New QERR_INVALID_PARAMETER_VALUE
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 975b63a4ee43870ffd96ce358ce597e42fbe1e1e
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:32 2010 +0100
error: Convert qemu_opts_create() to QError
Fixes device_add to report duplicate ID properly in QMP, as
DuplicateId instead of UndefinedError.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 7bc8401712d70dc12f230fb69cdb38511fd021b1
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:31 2010 +0100
error: New QERR_DUPLICATE_ID
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 9d494c4b4e7cd2b30b988f3f28c34917c5ae53f5
Author: Markus Armbruster <armbru at redhat.com>
Date: Thu Mar 25 17:22:30 2010 +0100
error: Put error definitions back in alphabetical order
Add suitable comments to help keerp them in order.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 17a38eaa2fdbb9add961e974fdb1b0ca8260813c
Author: Markus Armbruster <armbru at redhat.com>
Date: Mon Mar 22 11:38:14 2010 +0100
monitor: convert do_device_del() to QObject, QError
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit cc601cb785bbbd1a017d05d69763cd2c2e1ca3a4
Author: Markus Armbruster <armbru at redhat.com>
Date: Mon Mar 22 11:38:13 2010 +0100
qdev: Convert qdev_unplug() to QError
Note: our device unplug methods don't need conversion work, because
they can't currently fail.
Signed-off-by: Markus Armbruster <armbru at redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino at redhat.com>
commit 07a5d95a3b32820662194d353da9c098adddde77
Author: Ryan Harper <ryanh at us.ibm.com>
Date: Thu Mar 25 09:32:58 2010 -0500
Add qerror message if the 'change' target filename can't be opened
Currently when using the change command to switch the file in the cd drive
the command doesn't complain if the file doesn't exit or can't be opened
and the drive keeps the existing image. This patch adds a qerror_report
call to print a message out indicating the failure. This error message
can be used to catch failures.
Current behavior:
QEMU 0.12.50 monitor - type 'help' for more information
(qemu) info block
ide0-hd0: type=hd removable=0 file=/dev/null ro=0 drv=host_device encrypted=0
ide1-cd0: type=cdrom removable=1 locked=0 [not inserted]
floppy0: type=floppy removable=1 locked=0 [not inserted]
sd0: type=floppy removable=1 locked=0 [not inserted]
(qemu) change ide1-cd0 /home/rharper/work/isos/Fedora-9-i386-DVD.iso
(qemu) info block
ide0-hd0: type=hd removable=0 file=/dev/null ro=0 drv=host_device encrypted=0
ide1-cd0: type=cdrom removable=1 locked=0
file=/home/rharper/work/isos/Fedora-9-i386-DVD.iso ro=0 drv=raw encrypted=0
floppy0: type=floppy removable=1 locked=0 [not inserted]
sd0: type=floppy removable=1 locked=0 [not inserted]
(qemu) change ide1-cd0 /tmp/non_existent_file.iso
(qemu) info block
ide0-hd0: type=hd removable=0 file=/dev/null ro=0 drv=host_device encrypted=0
ide1-cd0: type=cdrom removable=1 locked=0 [not inserted]
floppy0: type=floppy removable=1 locked=0 [not inserted]
sd0: type=floppy removable=1 locked=0 [not inserted]
(qemu)
With patch:
QEMU 0.12.50 monitor - type 'help' for more information
(qemu) change ide1-cd0 /tmp/non_existent_file.iso
Could not open '/tmp/non_existent_file.iso'
(qemu)
Signed-off-by: Ryan Harper <ryanh at us.ibm.com>
Signed-off-by: Aurelien Jarno <aurelien at aurel32.net>
commit 7107944a7b72ec31366c30d747fb91dee07ebc88
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 18 14:27:46 2010 +0000
slirp: fix unused return value, spotted by clang
Fix clang errors like:
CC slirp/cksum.o
/src/qemu/slirp/cksum.c:78:3: error: expression result unused [-Wunused-value]
REDUCE;
/src/qemu/slirp/cksum.c:45:66: note: instantiated from:
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 156aa8981a26ea6a71028edf85410b02e6f23654
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 18 14:27:44 2010 +0000
i386-dis: Fix unused return value, spotted by clang
Fix clang erros like:
CC libdis/i386-dis.o
/src/qemu/i386-dis.c:3323:7: error: expression result unused [-Wunused-value]
FETCH_DATA (the_info, codep + 1);
/src/qemu/i386-dis.c:285:6: note: instantiated from:
? 1 : fetch_data ((info), (addr)))
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 7b13448f05882b98c836c32329b1aca347abeb52
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 18 14:26:51 2010 +0000
PPC: avoid function pointer type mismatch, spotted by clang
Fixes clang errors:
CC ppc-softmmu/translate.o
/src/qemu/target-ppc/translate.c:3748:13: error: comparison of distinct pointer types ('void (*)(void *, int, int)' and 'void *')
if (likely(read_cb != SPR_NOACCESS)) {
/src/qemu/target-ppc/translate.c:3748:28: note: instantiated from:
if (likely(read_cb != SPR_NOACCESS)) {
/src/qemu/target-ppc/translate.c:3903:13: error: comparison of distinct pointer types ('void (*)(void *, int, int)' and 'void *')
if (likely(write_cb != SPR_NOACCESS)) {
/src/qemu/target-ppc/translate.c:3903:29: note: instantiated from:
if (likely(write_cb != SPR_NOACCESS)) {
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 8c0d577eb5e5255333e43bd4b89dc3a266f03685
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 18 14:22:14 2010 +0000
kvm: avoid collision with dprintf macro in stdio.h, spotted by clang
Fixes clang errors:
CC i386-softmmu/kvm.o
/src/qemu/target-i386/kvm.c:40:9: error: 'dprintf' macro redefined
In file included from /src/qemu/target-i386/kvm.c:21:
In file included from /src/qemu/qemu-common.h:27:
In file included from /usr/include/stdio.h:910:
/usr/include/bits/stdio2.h:189:12: note: previous definition is here
CC i386-softmmu/kvm-all.o
/src/qemu/kvm-all.c:39:9: error: 'dprintf' macro redefined
In file included from /src/qemu/kvm-all.c:23:
In file included from /src/qemu/qemu-common.h:27:
In file included from /usr/include/stdio.h:910:
/usr/include/bits/stdio2.h:189:12: note: previous definition is here
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 6ad6135dcaec584958179bb57a954d3f8d890919
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 18 14:22:14 2010 +0000
Fix harmless if statements with empty body, spotted by clang
These clang errors are harmless but worth fixing:
CC ppc-softmmu/usb-ohci.o
/src/qemu/hw/usb-ohci.c:1104:59: error: if statement has empty body [-Wempty-body]
ohci->ctrl_head, ohci->ctrl_cur);
/src/qemu/hw/usb-ohci.c:1371:57: error: if statement has empty body [-Wempty-body]
DPRINTF("usb-ohci: port %d: SUSPEND\n", portnum);
CC sparc64-softmmu/translate.o
/src/qemu/target-sparc/translate.c:3173:37: error: if statement has empty body [-Wempty-body]
; // XXX
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 676d9b9b883691cf99e298291dbc2ad7956516b9
Author: Artyom Tarasenko <atar4qemu at googlemail.com>
Date: Sun Apr 18 00:34:03 2010 +0200
sparc32 use empty_slot for missing RAM v1
use empty_slot device for the RAM which is not installed
Models without ECC don't trap when missing ram is accessed.
v0->v1 compile only once and fix indentation
Signed-off-by: Artyom Tarasenko <atar4qemu at gmail.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit da9fcfa54486797a5f261b43ad0c0b2f8dc47181
Author: Artyom Tarasenko <atar4qemu at googlemail.com>
Date: Sat Apr 17 01:10:04 2010 +0200
create empty_slot device
The empty_slot device emulates known to a bus but not connected devices.
Signed-off-by: Artyom Tarasenko <atar4qemu at gmail.com>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 3c83eb4f17ffa981cb60b965087769b808062a3a
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sun Apr 18 08:45:03 2010 +0000
Fix harmless if statements with empty body, spotted by clang
These clang errors are harmless but worth fixing:
CC libhw64/fdc.o
/src/qemu/hw/fdc.c:998:74: error: if statement has empty body [-Wempty-body]
FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval);
CC libhw64/cuda.o
/src/qemu/hw/cuda.c:320:66: error: if statement has empty body [-Wempty-body]
CUDA_DPRINTF("read: reg=0x%x val=%02x\n", (int)addr, val);
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 606257c6f2dbbaa63f462e557f15a5f7364967a6
Author: malc <av1474 at comtv.ru>
Date: Sun Apr 18 08:46:29 2010 +0400
tcg/ppc: Remove redundant comparison from brcond2
Signed-off-by: malc <av1474 at comtv.ru>
commit 2d8ebcf94ee461dea9eb363be7becb769d9a962f
Author: Richard Henderson <rth at twiddle.net>
Date: Sat Apr 17 16:25:10 2010 +0000
Fix --enable-profiler compilation.
There's a header file inclusion ordering problem between cpu-all.h
and qemu-timer.h, such that cpu_get_real_ticks is not defined when
we attempt to use it in profile_getclock.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 42a8aa8393b931c92662578bc6b0b82c54fe63f8
Author: Richard Henderson <rth at twiddle.net>
Date: Sat Apr 17 16:25:08 2010 +0000
target-sparc: Free instruction temporaries.
Rather than creating new temporaries for constants, use the
ones created in disas_sparc_insn. Remember the temps created
there so that they can be freed at the end of the function.
Profile data collected by TCG while booting sparc-test kernel:
-avg temps/TB 70.61 max=421
+avg temps/TB 62.75 max=66
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 058ed88cc115e6b8323a39d7f05e6cf91b19b35e
Author: Richard Henderson <rth at twiddle.net>
Date: Sat Apr 17 16:25:06 2010 +0000
target-sparc: Fix TARGET_{PHYS,VIRT}_ADDR_SPACE_BITS.
The 32 and 64-bit definitions were swapped in the ifdef.
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit cca1d527efaa8ce65b4a78f936af82cc7cc96e82
Author: Blue Swirl <blauwirbel at gmail.com>
Date: Sat Apr 17 16:25:04 2010 +0000
Sparc: fix PC/NPC during FPU traps
All FPU instructions can trap, so save PC/NPC state before
executing them.
Signed-off-by: Blue Swirl <blauwirbel at gmail.com>
commit 655feed5d9889a0391023ee518bcba4dbd09438c
Author: malc <av1474 at comtv.ru>
Date: Sat Apr 17 07:59:26 2010 +0400
tcg: Add missing static qualifier
Build breaks otherwise when USE_LIVENESS_ANALYSIS is not defined.
Signed-off-by: malc <av1474 at comtv.ru>
commit efe72c8de7b5f07bf8348d51ed4bb4f004e50748
Author: malc <av1474 at comtv.ru>
Date: Sat Apr 17 07:58:08 2010 +0400
tcg/ppc: Fix signed versions of brcond2
Thanks to: Alexander Graff, Thomas Gleixner and Andreas Faerber.
Signed-off-by: malc <av1474 at comtv.ru>
commit a491cf58dbe320511b1d3d053870baba2c7f0384
Author: Arnaud Lacombe <lacombar at gmail.com>
Date: Tue Apr 13 21:25:25 2010 -0400
Fix format strings
This fix the following build failure:
CC libdis-user/microblaze-dis.o
cc1: warnings being treated as errors
microblaze-dis.c: In function 'print_insn_microblaze':
microblaze-dis.c:829: warning: format '%04x' expects type 'unsigned int',
but argument 4 has type 'long unsigned int'
microblaze-dis.c:962: warning: format '%04x' expects type 'unsigned int',
but argument 4 has type 'long unsigned int'
Reported-at: http://www.monstr.eu/wiki/doku.php?id=log:2010-04-13_12_10_00
Signed-off-by: Edgar E. Iglesias <edgar.iglesias at gmail.com>
More information about the Spice-commits
mailing list