[Spice-commits] Changes to 'spice-patches'

Hans de Goede jwrdegoede at kemper.freedesktop.org
Tue May 3 06:55:44 PDT 2011


New branch 'spice-patches' available with the following commits:
commit 586a84c6a7d3a98f16c670b7e08f0ca7777f9e12
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Sun Mar 27 16:43:54 2011 +0200

    spice: add option for disabling copy paste support
    
    Some people want to be able disable spice's guest <-> client copy paste support
    because of security considerations.

commit d4319e03f867171b7af1aa5228540575bce543ae
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Tue Mar 22 16:28:41 2011 +0100

    spice-qemu-char: Fix flow control in client -> guest direction
    
    In the old spice-vmc device we used to have:
    last_out = virtio_serial_write(&svc->port, p, MIN(len, VMC_MAX_HOST_WRITE));
    if (last_out > 0)
       ...
    
    Now in the chardev backend we have:
    last_out = MIN(len, VMC_MAX_HOST_WRITE);
    qemu_chr_read(scd->chr, p, last_out);
    if (last_out > 0) {
       ...
    
    Which causes us to no longer detect if the virtio port is not ready
    to receive data from us. chardev actually has a mechanism to detect this,
    but it requires a separate call to qemu_chr_can_read, before calling
    qemu_chr_read (which return void).
    
    This patch uses qemu_chr_can_read to fix the flow control from client to
    guest.
    
    Signed-off-by: Hans de Goede <hdegoede at redhat.com>



More information about the Spice-commits mailing list