[Spice-commits] 2 commits - server/reds.c

[Frediano Ziglio]

 server/reds.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a1a64a41f83141b913e0a7125b7363e0458c5ab8
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Tue Dec 12 17:20:39 2017 +0000

    reds: Remove unused SASL_DATA_MAX_LEN define
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Jonathon Jongsma <jjongsma at redhat.com>

diff --git a/server/reds.c b/server/reds.c
index 384ebc58..2b16c6d7 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2112,7 +2112,6 @@ static void reds_get_spice_ticket(RedLinkInfo *link)
  * u8-array serverout-strin
  * u8 continue
  */
-#define SASL_DATA_MAX_LEN (1024 * 1024)
 
 static void reds_handle_auth_sasl_steplen(void *opaque);
 
commit 83c5fa8d325525cadd439f0e05cfdcc0ca2964b0
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Tue Dec 12 17:20:39 2017 +0000

    reds: Remove possible leak during SASL authentication
    
    We need to free the connection if the mechanism name is wrong
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Uri Lublin <uril at redhat.com>

diff --git a/server/reds.c b/server/reds.c
index e7b95980..384ebc58 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2202,6 +2202,7 @@ static void reds_handle_auth_mechname(void *opaque)
 
     if (!red_sasl_handle_auth_mechname(link->stream, reds_handle_auth_startlen, link)) {
             reds_send_link_error(link, SPICE_LINK_ERR_INVALID_DATA);
+        reds_link_free(link);
     }
 }