[Spice-devel] [PATCH 16/30] Convert cairo canvas alpha_blend to using pixman

[Izik Eidus]

On Thu, 18 Feb 2010 21:58:42 +0100
Alexander Larsson <alexl at redhat.com> wrote:


> +
> +    if (mask)
> +        pixman_image_unref (mask);
> 

Any strong feelings against changing it to
if (mask) {
     pixman_image_unref (mask);
}

While I dont think it the end of the world, we should at least know
that if we enter:
   if (mask)
       pixman_image_unref (mask);

We will have code that partly do it with { } and partly without it.

So we have 3 options:

1) decide that both are allowed

2) decide that just if (mask) pixman_image_unref (mask);, is allowed

3) decide that just if (mask) { pixman_image_unref (mask); } is allowed


What you think?

Thanks.