[Spice-devel] [PATCH] windows client: add --include "common.h"-- for generated demarshallers

[Alexander Larsson]

On Wed, 2010-06-23 at 17:53 +0300, Yonit Halperin wrote:
> On 06/23/2010 05:53 PM, Alexander Larsson wrote:
> > On Wed, 2010-06-23 at 14:29 +0300, Yonit Halperin wrote:
> >> ---
> >>   client/windows/generate.bat  |    2 +-
> >>   client/windows/generate1.bat |    2 +-
> >>   2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/client/windows/generate.bat b/client/windows/generate.bat
> >> index 1bb62b4..6bd06d7 100644
> >> --- a/client/windows/generate.bat
> >> +++ b/client/windows/generate.bat
> >> @@ -1,2 +1,2 @@
> >>   python ..\..\spice_codegen.py -d -c  -i common.h -i messages.h ..\..\spice.proto ..\generated_demarshallers.cpp
> >> -python ..\..\spice_codegen.py --generate-marshallers -P --include messages.h --include marshallers.h --client ..\..\spice.proto ..\generated_marshallers.cpp
> >> +python ..\..\spice_codegen.py --generate-marshallers -P --include "common.h" --include messages.h --include marshallers.h --client ..\..\spice.proto ..\generated_marshallers.cpp
> >> diff --git a/client/windows/generate1.bat b/client/windows/generate1.bat
> >> index d720353..8c54e4c 100644
> >> --- a/client/windows/generate1.bat
> >> +++ b/client/windows/generate1.bat
> >> @@ -1,2 +1,2 @@
> >>   python ..\..\spice_codegen.py -d -c  -i common.h -i messages.h --prefix 1 ..\..\spice1.proto ..\generated_demarshallers1.cpp
> >> -python ..\..\spice_codegen.py --generate-marshallers -P --include messages.h  --include marshallers.h --client --prefix 1 ..\..\spice1.proto ..\generated_marshallers1.cpp
> >> +python ..\..\spice_codegen.py --generate-marshallers -P --include "common.h" --include messages.h  --include marshallers.h --client --prefix 1 ..\..\spice1.proto ..\generated_marshallers1.cpp
> >
> > Hmm? Why is this needed? Its not done in the unix side
> > (client/Makefile.am). At the very least these should produce the same
> > code, so if its needed on win32 we should add it on unix too. However,
> > it built for me on win32 without this. How does it fail for you?
> >
> something like: "Unexpected end of file, did you forget to include 
> "common.h"?
> Why then commom.h is added to the marshallers and not to the demarshallers?

Ah, precompiled headers then?

But, if you do this change, also change it in client/Makefile.am,
because we might be generating the code on linux for the tarball and
then building it on win32.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's an underprivileged sweet-toothed waffle chef who knows the secret of the 
alien invasion. She's a hard-bitten impetuous magician's assistant with a song 
in her heart and a spring in her step. They fight crime!