[Spice-devel] [PATCH 1/3] remove unnecessary send of SPICE_MSG_DISPLAY_RESET

Yonit Halperin yhalperi at redhat.com
Sun Jun 27 02:45:11 PDT 2010


when SPICE_MSG_DISPLAY_RESET was sent, SPICE_MSG_DISPLAY_SURFACE_DESTROY had already
been sent for all surfaces.
It also caused a client crash since DisplayChannel::handle_reset assumes that screen
exists.
---
 server/red_worker.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/server/red_worker.c b/server/red_worker.c
index 47bfae5..9a7df1f 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -11012,9 +11012,6 @@ static inline void handle_dev_destroy_surfaces(RedWorker *worker)
     if (worker->display_channel) {
         red_pipe_add_type(&worker->display_channel->base, PIPE_ITEM_TYPE_INVAL_PALLET_CACHE);
         red_pipe_add_verb(&worker->display_channel->base, SPICE_MSG_DISPLAY_STREAM_DESTROY_ALL);
-        if (!worker->display_channel->base.migrate) {
-            red_pipe_add_verb(&worker->display_channel->base, SPICE_MSG_DISPLAY_RESET);
-        }
     }
 
     //to handle better
-- 
1.6.6.1



More information about the Spice-devel mailing list