[Spice-devel] [PATCH 20/35] VDInterface: redesign.

[Gerd Hoffmann]

   Hi,

>> +        if (interface->major_version != VD_INTERFACE_NET_WIRE_MAJOR ||
>> +            interface->minor_version<  VD_INTERFACE_NET_WIRE_MINOR) {
>> +            red_printf("unsuported net wire interface");
>> +            return -1;
>> +        }
>> +        red_tunnel = red_tunnel_attach(core, net_wire);
>>   #else
>> -            red_printf("unsupported net wire interface");
>> +        red_printf("unsupported net wire interface");
>>   #endif
>
> The switch from not returning anything to returning -1 on failure means
> that #else HAVE_SLIRP case need to return -1.

Right, fixed.

cheers,
   Gerd