[Spice-devel] [PATCH 28/35] vdi port: redesign.

[Gerd Hoffmann]

   Hi,

>> -    while (reds->agent_state.plug_ref != INVALID_VD_OBJECT_REF) {
>> +    sif = SPICE_CONTAINEROF(vdagent->base.sif, SpiceVDIPortInterface, base);
>> +    for (;;) {
>
> Changing a while to for(;;;) doesn't seem right. We can still hit:
>
>   read_from_vdi_port()->  dispatch_vdi_port_data()->  default: ->
>   reds_agent_remove()
>
> which used to set plug_ref to INVALID_VD_OBJECT_REF, only now it sets
> connected to 0 instead, so we should check that.

Good point.  Fixed.

thanks,
   Gerd