[Spice-devel] [PATCH 38/39] zap vd_interface.h

[Alexander Larsson]

On Wed, 2010-05-19 at 11:11 +0200, Gerd Hoffmann wrote:
> On 05/19/10 10:45, Alexander Larsson wrote:
> > On Tue, 2010-05-18 at 17:43 +0200, Gerd Hoffmann wrote:
> >> +struct SpiceRect;
> >> +struct QXLWorker {
> >> +    uint32_t minor_version;
> >> +    uint32_t major_version;
> >> +    void (*wakeup)(QXLWorker *worker);
> >> +    void (*oom)(QXLWorker *worker);
> >> +    void (*start)(QXLWorker *worker);
> >> +    void (*stop)(QXLWorker *worker);
> >> +    void (*update_area)(QXLWorker *qxl_worker, uint32_t surface_id,
> >> +                       struct SpiceRect *area, struct SpiceRect *dirty_rects,
> >> +                       uint32_t num_dirty_rects, uint32_t clear_dirty_region);
> >
> >
> > I don't like how this puts the SpiceRect typedef in the public API,
> 
> I don't put it there.  It already is there, I'm just moving the bits 
> from one header to another.
> 
> I agree that it needs fixing, but that is IMHO independent from this 
> patch series.

Yeah, just pointing it out when i saw it.

> > as
> > we want to convert all Spice types that qxl uses to qxl specific types
> > (i.e. QXLRect), and then make SpiceRect internal (in fact we want to
> > change SpiceRect to be binary compat with the pixman box_t type).
> >
> > Furthermore, the API as is doesn't even define SpiceRect as it doesn't
> > pull in the right header from spice-protocol for it. I'm not sure what
> > the best approach here is. We should add QXLRect to qxl_dev.h and just
> > use it for update_area for now.
> 
> qxl_dev.h uses SpiceRect too.  Wasn't there a patch from izik which 
> started cleaning that up and separate QXL* and Spice* types?

Yeah, this is 
http://www.spice-space.org/page/Features/PCICompatLayer

I added iziks initial patch to 
https://bugs.freedesktop.org/show_bug.cgi?id=28171

I haven't looked at it yet, but its not supposed to be in any finished
state.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's a sword-wielding chivalrous messiah on the edge. She's a beautiful 
psychic pearl diver in the wrong place at the wrong time. They fight crime!