[Spice-devel] Replace epoll with select in X client

Alexander Larsson alexl at redhat.com
Wed Sep 29 08:38:17 PDT 2010


On Wed, 2010-09-29 at 17:28 +0200, Alexander Larsson wrote:

I'm commiting this part:

> diff --git a/client/x11/platform.cpp b/client/x11/platform.cpp
> index 1133414..ca5f1d5 100644
> --- a/client/x11/platform.cpp
> +++ b/client/x11/platform.cpp
> @@ -3024,8 +3024,12 @@ void Platform::set_clipboard_listener(ClipboardListener* listener)
>          return;
>      }
>      clipboard_listener = listener;
> -    XConvertSelection(x_display, XA_PRIMARY, utf8_atom, clipboard_prop,
> -        platform_win, CurrentTime);
> +    /* Seems platform_win can be NULL, we'll just ignore that for now.
> +       This will be fixed when the rest of cut and paste lands */
> +    if (platform_win) {
> +      XConvertSelection(x_display, XA_PRIMARY, utf8_atom, clipboard_prop,
> +			platform_win, CurrentTime);
> +    }
>  }
>  

As it works around crashes here. Then i'll do the 0.6.1 release and we
can land this post release.



More information about the Spice-devel mailing list