[Spice-devel] [PATCH 00/12] More cleanups

[Christophe Fergeau]

Here are again some cleanups, the main highlights are the use of
gcc builtin atomic functions to remove some x86 assembly, after
this there should no longer be some mandatory x86 assembly, the only
remaining bits are a function to get the index of the most significant
bit in an integer, and there's a C fallback.

It also removes some duplicated PANIC/ASSERT/WARN/WARN_ONCE macros and
consolidate everything in common/spice_common.h. There are still a 2nd
copy of these macros in client/debug.h, I haven't taken of them for now
since this is a bit tricky, they rely on Application::spice_log to do
some detailed logging of the context in which the panic was risen.

There are also a few more cleanups

Christophe


Christophe Fergeau (12):
  win32: remove obsolete preprocessor #defines
  configure.ac: remove setting default C(XX)FLAGS
  add missing static
  remove void * arithmetic
  common: don't duplicate find_msb implementation
  client: remove unused mb() macro
  server: use gcc builtin for atomic get/set bit
  common,server: use ASSERT from spice_common.h
  common: use PANIC from spice_common.h
  move WARN and WARN_ONCE to spice_common.h
  use standard do { } while (0) for spice_common.h macros
  move get_time_stamp to main_channel.c

 client/jpeg_decoder.cpp     |    2 +-
 client/red_channel.cpp      |    2 +-
 client/windows/redc.vcproj  |    8 ++--
 client/x11/platform_utils.h |    6 ---
 common/bitops.h             |   89 +++++++++++++++++++++++++++++++++++++++++++
 common/canvas_base.c        |   14 -------
 common/canvas_utils.c       |    8 ----
 common/gl_utils.h           |   58 +--------------------------
 common/glc.c                |   10 -----
 common/ogl_ctx.c            |    6 ---
 common/pixman_utils.c       |   15 +-------
 common/quic.c               |   14 +------
 common/quic_family_tmpl.c   |    4 +-
 common/region.c             |    5 --
 common/rop3.c               |   16 +------
 common/spice_common.h       |   32 +++++++---------
 configure.ac                |   12 ------
 server/main_channel.c       |    7 +++
 server/mjpeg_encoder.c      |    6 +-
 server/red_channel.c        |   10 ++--
 server/red_dispatcher.c     |    5 +-
 server/red_worker.c         |   14 +++---
 server/red_worker.h         |    6 ++-
 server/reds.c               |   18 ++++----
 server/reds_gl_canvas.c     |    2 +
 server/reds_sw_canvas.c     |    2 +
 26 files changed, 162 insertions(+), 209 deletions(-)
 create mode 100644 common/bitops.h

-- 
1.7.4.4