[Spice-devel] Spice on OS/X

Christophe Fergeau cfergeau at redhat.com
Wed Apr 27 10:28:18 PDT 2011


On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote:
> diff --git a/gtk/continuation.h b/gtk/continuation.h
> index 585788e..6822757 100644
> --- a/gtk/continuation.h
> +++ b/gtk/continuation.h
> @@ -21,7 +21,8 @@
>  #ifndef _CONTINUATION_H_
>  #define _CONTINUATION_H_
>  
> -#include <ucontext.h>
> +#include <string.h>
> +#include <sys/ucontext.h>
> 
> Ah, this explains the #include <ucontext.h> you added in the previous hunk.
> I suspect dropping both hunks and only adding the #define _XOPEN_SOURCE
> here would fix your issues. Though nothing in ucontext.h nor in
> sys/ucontext.h on a macosx box depends on _XOPEN_SOURCE, so I'm not sure
> what issues you were seeing here?

For the record, on the osx build I tried, I only had to add #include
<stddef.h> to continuation.h, and didn't need to define _XOPEN_SOURCE in
continuation.[ch].
string.h wasn't needed here, but I had to add it to ssl_verify.c. On my
leopard system, openssl was too old and EVP_PKEY_cmp didn't exist (it was
introduced in openssl 0.9.8). Copying the openssl 0.9.8 implementation in
the file was enough to workaround the problem, so we can probably test for
its presence in configure.ac and conditionally compile such code if the
function wasn't available.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110427/361ad0f1/attachment.pgp>


More information about the Spice-devel mailing list