[Spice-devel] [PATCH 1/3] vdservice: don't close pipe if overlapped I/O event is not in signaled state (rhbz#667777)

[Alon Levy]

On Thu, Apr 28, 2011 at 11:58:40AM +0300, Arnon Gilboa wrote:
> which is beacuse ReadFile completed successfully without pending and the data was already consumed
> ---
>  vdservice/vdservice.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

ACK series. A better comment for the third patch would be to specify what
inconsistent means - that there are some devices with a QXL driver and some without.

> diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
> index 175587c..85fa182 100644
> --- a/vdservice/vdservice.cpp
> +++ b/vdservice/vdservice.cpp
> @@ -512,7 +512,7 @@ bool VDService::execute()
>                                              &bytes, FALSE) || GetLastError() == ERROR_MORE_DATA) {
>                          handle_pipe_data(bytes);
>                          read_pipe();
> -                    } else {
> +                    } else if (GetLastError() != ERROR_IO_INCOMPLETE) {
>                          vd_printf("GetOverlappedResult failed %u", GetLastError());
>                          _pipe_connected = false;
>                          DisconnectNamedPipe(_pipe_state.pipe);
> -- 
> 1.7.4.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel