[Spice-devel] [PATCH 1/3] always set VDAgentDisplayConfig::depth

Hans de Goede hdegoede at redhat.com
Fri Aug 12 23:52:24 PDT 2011


All 3 Look good to me.

ACK series.

Regards,

Hans


On 08/12/2011 06:03 PM, Christophe Fergeau wrote:
> Even if VDAgentDisplayConfig::depth will be unused if the
> VD_AGENT_DISPLAY_CONFIG_FLAG_SET_COLOR_DEPTH isn't set, it's
> better to initialize it anyway to avoid warnings from valgrind.
> ---
>   client/red_client.cpp |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/client/red_client.cpp b/client/red_client.cpp
> index e084759..efd9feb 100644
> --- a/client/red_client.cpp
> +++ b/client/red_client.cpp
> @@ -740,6 +740,7 @@ void RedClient::send_agent_display_config()
>           spice_marshaller_reserve_space(message->marshaller(), sizeof(VDAgentDisplayConfig));
>
>       disp_config->flags = 0;
> +    disp_config->depth = 0;
>       if (_display_setting._disable_wallpaper) {
>           disp_config->flags |= VD_AGENT_DISPLAY_CONFIG_FLAG_DISABLE_WALLPAPER;
>       }


More information about the Spice-devel mailing list