[Spice-devel] [spice-0.8] client: Plug some leaks

Christophe Fergeau cfergeau at redhat.com
Wed Aug 17 09:35:21 PDT 2011


Hey,

These fixes duplicate fixes that already went into master :-/ See commits
d7d0a3a98e and 0d4bd5504.

On Wed, Aug 17, 2011 at 05:35:17PM +0300, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
> diff --git a/client/x11/red_window.cpp b/client/x11/red_window.cpp
> index d53a92f..f3ff95f 100644
> --- a/client/x11/red_window.cpp
> +++ b/client/x11/red_window.cpp
> @@ -1313,6 +1313,7 @@ void RedWindow_p::move_to_current_desktop()
>                             &bytes_after_return, &prop_return) == Success &&
>                                           actual_type_return != None && actual_format_return == 32) {
>          desktop = *(uint32_t *)prop_return;
> +        XFree(prop_return);

prop_return will still be leaked when actual_type_return is None or
when actual_format_return is != 32 (maybe that can't happen ?)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110817/36b3d471/attachment.pgp>


More information about the Spice-devel mailing list