[Spice-devel] [PATCH 1/2] free main channel on shutdown

Alon Levy alevy at redhat.com
Wed Aug 17 10:55:53 PDT 2011


On Wed, Aug 17, 2011 at 12:20:11PM +0200, Christophe Fergeau wrote:
> Ping?
> 

I'm going to be pushing the multiclient patches, including Yonit's changes
that kill the Channel struct and reuse RedChannel for that, Any Day Now, I
so this will be redundant. (and maybe you'll find a new leak afterwards :/ )

> Christophe
> 
> On Tue, Aug 09, 2011 at 07:09:37PM +0200, Christophe Fergeau wrote:
> > If we don't free it, we'll leak the memory that was allocated in
> > main_channel_init().
> > ---
> >  server/main_channel.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/server/main_channel.c b/server/main_channel.c
> > index 1a6a89c..460c21b 100644
> > --- a/server/main_channel.c
> > +++ b/server/main_channel.c
> > @@ -860,6 +860,7 @@ static void main_channel_shutdown(Channel *channel)
> >      if (main_chan != NULL) {
> >          main_disconnect(main_chan);
> >      }
> > +    free(channel);
> >  }
> >  
> >  static void main_channel_migrate()
> > -- 
> > 1.7.6
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel



> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel



More information about the Spice-devel mailing list