[Spice-devel] [PATCH 0/3] small cleanup for the multiclient branch

Christophe Fergeau cfergeau at redhat.com
Sun Aug 21 23:39:17 PDT 2011


Hey,

I've been looking at the multiclient branch this morning, in particular
commit c1b3e13ee3549 server/main_channel: support multiple clients.
The AgentDataPipeItemRefs stuff got me really confused, after a while I think
I figured it out, ie, AgentDataPipeItemRefs is used to reference count the
data associated with the AgentDataPipeItem. These 3 patches make this code
much more obvious in my opinion. That is, if I understood the code properly
:p The multiclient branch could probably even be rebased on top of these
changes to make the "support multiple clients" commit as small as possible.

Let me know what you think, and if I properly understood this
AgentDataPipeItemRefs code, hopefully I'll be online sometime around the
weekly phone call.

Christophe


Christophe Fergeau (3):
  add spice_chunk_get_{data,len}
  add SpiceRefcountedChunk
  simplify agent data pipe item

 common/mem.c          |   68 +++++++++++++++++++++++++++++++++++++++++++++++++
 common/mem.h          |    9 ++++++
 server/main_channel.c |   51 +++++++++---------------------------
 3 files changed, 90 insertions(+), 38 deletions(-)

-- 
1.7.6



More information about the Spice-devel mailing list