[Spice-devel] [PATCH 1/3] fix inverted memset parameters

Hans de Goede hdegoede at redhat.com
Wed Aug 24 01:01:52 PDT 2011


Good work!

Ack series.

I think we should add these to the 0.8 branch too.


On 08/24/2011 04:41 AM, Christophe Fergeau wrote:
> Issue found by the Coverity scanner.
> ---
>   server/red_dispatcher.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
> index c00dc58..721c79c 100644
> --- a/server/red_dispatcher.c
> +++ b/server/red_dispatcher.c
> @@ -426,7 +426,7 @@ static void red_dispatcher_create_primary_surface_complete(RedDispatcher *dispat
>       dispatcher->primary_active = TRUE;
>
>       update_client_mouse_allowed();
> -    memset(&dispatcher->surface_create, sizeof(QXLDevSurfaceCreate), 0);
> +    memset(&dispatcher->surface_create, 0, sizeof(QXLDevSurfaceCreate));
>   }
>
>   static void


More information about the Spice-devel mailing list