[Spice-devel] [PATCH] plugin: try to run only /usr/libexec/spice-xpi-client

Marc-André Lureau mlureau at redhat.com
Tue Jun 28 02:45:22 PDT 2011


hi

----- Original Message -----
> On 06/28/2011 01:55 AM, Marc-André Lureau wrote:
> > Although not really important, the previous code was racy (stat +
> > exec).
> 
> What seems to be the problem with it ?

There is time between stat() and exec(), you can only reliably do exec() only. But well, not that important anyway. If we need a second location, I'd suggest using an environment variable (that would allow to point to custom /home/src/spice clients for example).

> >
> > I propose running /usr/libexec/spice-xpi-client without parameters,
> > which could be a shell script with the required arguments to call
> > spicec or other spice clients (and could be easily tweaked to run
> > various clients depending on environment etc..)
> 
> spice-xpi must know the pid of the spice client it runs. I'm not sure
> how well
> that would work with a shell script. Needs testing.

it works fine if you simply 'exec spicec --controller "$@"' for example.

regards

-- 
Marc-André Lureau



More information about the Spice-devel mailing list