[Spice-devel] [RfC PATCH 1/7] spice: add worker wrapper functions.

Alon Levy alevy at redhat.com
Wed Jun 29 03:10:56 PDT 2011


On Wed, Jun 29, 2011 at 11:55:09AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >zeroing the guest_surfaces should be moved to
> >qemu_spice_destroy_surfaces. It is an older bug that it wasn't preformed
> >on QXL_IO_DESTROY_ALL_SURFACES (which isn't actually called now, but
> >once S3 support is committed, it will). The zeroing must be performed
> >synchronically with worker->destroy_surfaces, since otherwise,
> >asynchronous worker calls to interface_get_command might change the
> >guest_surfaces again.
> >Also, not related to async io - the guest_surfaces.count should be
> >zeroed too.
> 
> Updates (incremental fixes) pushed to
> http://localhost/cgit/projects/qemu/.git/log/?h=bz700134
> 
> Fixed this, also picked some of Alon's S3 patches.
> 
> cheers,
>   Gerd

ok, I want to send the v3 of S3 (rebased correctly and no primary_created bool,
reuse UNDEFINED for SURFACES_DESTROY), so can you put that somewhere public
so I can rebase on top of it?

> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list