[Spice-devel] [PATCH] Revert "server/smartcard: don't register the channel if no hardware emulated"

[Alon Levy]

On Wed, Jun 29, 2011 at 02:03:31PM +0200, Marc-André Lureau wrote:
> Still the idea was good... Can the smartcard channel initialization be
> delayed until the hardware is added?

We can register the channel only from device addition, yes. I can try that.

> 
> On Wed, Jun 29, 2011 at 12:07 PM, Alon Levy <alevy at redhat.com> wrote:
> > This reverts commit 456ff9f8d5d27ac763e89e67a100661084695dc5.
> >
> > That patch just disabled the smartcard channel completely because
> > the check was done *before* the initialization of the qemu smartcard
> > devices, not after.
> > ---
> >  server/smartcard.c |    5 +----
> >  1 files changed, 1 insertions(+), 4 deletions(-)
> >
> > diff --git a/server/smartcard.c b/server/smartcard.c
> > index 7830c9a..f948e5b 100644
> > --- a/server/smartcard.c
> > +++ b/server/smartcard.c
> > @@ -538,10 +538,6 @@ void smartcard_channel_init(void)
> >  {
> >     Channel *channel;
> >
> > -    /* don't register the channel if no hardware registered */
> > -    if (g_smartcard_readers.num == 0) {
> > -        return;
> > -    }
> >     channel = spice_new0(Channel, 1);
> >     channel->type = SPICE_CHANNEL_SMARTCARD;
> >     channel->link = smartcard_link;
> > @@ -549,3 +545,4 @@ void smartcard_channel_init(void)
> >     channel->migrate = smartcard_migrate;
> >     reds_register_channel(channel);
> >  }
> > +
> > --
> > 1.7.5.4
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >
> 
> 
> 
> -- 
> Marc-André Lureau