[Spice-devel] [PATCH v2 00/40] red channel refactor parts 3 and 4

Alon Levy alevy at redhat.com
Wed Mar 2 00:31:23 PST 2011


This is the sum of the previous part 3 v1 and part 4 v1, with some merging
so down from 49 to 40 patches (all renames are in the second patch).

v1->v2 changes: (Marc-Andre review fixes)
 + tunnel_channel builds again.
 + use accessors instead of augmenting callback signatures:
  - red_channel_get_marshaller
  - red_channel_get_header
 + introduce common/spice_common.h to make ring.h (in common) not to
   include a file in server.

Still fighting with git bz, next series will probably be there instead
of on the ML.

Alon Levy (40):
  server/red_tunnel_worker: use message_serial setter and getter
  server/red_worker: red_channel renames
  server/red_worker: add send_item
  server/red_worker: add red_channel_push
  server/red_worker: introduce red_channel_pipe_clear
  server/red_worker: don't push to NULL channel (called from device
    input)
  server/red_worker: line width fix
  server/red_worker: introduce common_channel_config_socket
  server/red_worker: introduce red_peer_handle_outgoing and
    OutgoingHandler
  server/red_channe: make hold_item take a channel arg
  server/red_worker: use red_channel
  server/red_channel (all): makes red_channel_reset_send_data private
  server: use red_channel_get_message_serial
  server/red_channel: add more ack api
  server/red_channel: move SET_ACK to red_channel
  server/inputs_channel: s/PIPE_ITEM_INIT/PIPE_ITEM_INPUTS_INIT/
  server/red_worker: use red_channel_destroy
  server/red_channel (all): add red_channel_get_marshaller
  server/red_channel (all): handle MIGRATE_DATA and MIGRATE_FLUSH_DATA
  server/common: introduce common/spice_common.h
  ring: add RING_FOREACH{,_SAFE,_REVERSED}
  server/red_channel (all): add red_channel_get_stream
  server/tunnel: pass SpiceMarshaller reference from send
  server/red_channel (+): remove red_channel_add_buf
  server/red_channel: add red_channel_get_first_socket
  server/red_channel (all): add red_channel_get_header
  server/red_worker: cursor channel: replace _send_ with _marshall_
  server/red_channel: add red_channel_all_blocked
  server/red_channel: add red_channel_send_message_pending
  server/red_worker: replace _send_ functions by _marshall_
  server/red_worker: complete removal of send_data.marshaller use
  server/red_channel: add red_channel_{,no_}item_being_sent
  server/red_worker: remove RedChannel argument from add_buf_from_info
  server/red_channel: reset send_data.item to NULL after release
  server/red_channel: add red_channel_disconnect, use in red_worker
  server/red_worker: use red_channel_is_connected
  server/red_channel: no opaque in red_channel_peer_on_*_error
  server/red_channel: split Incoming/Outgoing to callback and state
  server/red_channel: move out_bytes_counter from Outgoing to
    RedChannel
  server/red_worker: use red_channel_pipe_item_init

 common/ring.h                    |   21 +
 common/spice_common.h            |   70 +++
 server/inputs_channel.c          |   25 +-
 server/main_channel.c            |  150 +++---
 server/red_channel.c             |  279 +++++++--
 server/red_channel.h             |  125 ++++-
 server/red_client_cache.h        |    2 +-
 server/red_client_shared_cache.h |    8 +-
 server/red_common.h              |   46 +--
 server/red_tunnel_worker.c       |  232 ++++----
 server/red_worker.c              | 1189 ++++++++++++++------------------------
 server/smartcard.c               |   36 +-
 12 files changed, 1064 insertions(+), 1119 deletions(-)
 create mode 100644 common/spice_common.h

-- 
1.7.4.1



More information about the Spice-devel mailing list