[Spice-devel] [PATCH spice-protocol] macros: define INLINE

Arnon Gilboa agilboa at redhat.com
Thu May 12 02:51:29 PDT 2011


Christophe Fergeau wrote:
> Hi,
>
> On Thu, May 12, 2011 at 11:49:38AM +0300, Arnon Gilboa wrote:
>   
>> needed for spice/common files used by the client, server & qxl driver.
>> in windows _inline works for both c/c++, while inline is c++ only.
>> compiling the client with mixed c/c++ code required this define.
>>     
>
> If this change is done, it's a good opportunity to look at removing the
> similar #defines from spice/:
>
> $ git grep "define.*INLINE"
>
> common/lz_config.h:#define INLINE inline
> common/lz_config.h:#define INLINE _inline
> common/lz_config.h:#define INLINE inline
> common/quic_config.h:#define INLINE inline
> common/quic_config.h:#define INLINE _inline
> common/quic_config.h:#define INLINE inline
> server/glz_encoder_config.h:#define INLINE inline
>
> I assume there's a followup patch changing some inline to INLINE in
> spice/common? Can you send it as well?
>
> Thanks,
>
> Christophe
>   
done, except from  server/glz_encoder_config.h



More information about the Spice-devel mailing list