[Spice-devel] Question on fill_mask() (server/red_worker.c)

[Yaniv Kaul]

On 10/04/2011 01:00 PM, Alon Levy wrote:
> On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote:
>> Unless I'm misreading the code (which may very well be), the
>> function looks like:
>>
>> if (mask_bitmap&&  m) {
>>      if (this or that) {
>>          do X
>>          fill_bits(...)
>>      } else {
>>          fill_bits(...)
>>      }
>> }
>>
>> So essentially, if the condition (mask_bitmap&&  m) is NOT met, we
>> do not fill the bits. Which means we are sending garbage over the
>> wire?
> I read it the same. Can you add the else and see if it gets there? (or
> figure that out by just reading the code)

diff --git a/server/red_worker.c b/server/red_worker.c
index 7af715d..5bd3a92 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -6415,6 +6415,8 @@ static void fill_mask(RedChannelClient *rcc, 
SpiceMarshaller *m,
          } else {
              fill_bits(dcc, m, mask_bitmap, drawable, FALSE);
          }
+    } else {
+       red_printf("fill_mask not doing much");
      }
  }

...
reds_handle_read_link_done: Peer doesn't support AUTH selection
reds_show_new_channel: channel 3:0, connected successfully, over Non 
Secure link
inputs_connect: inputs channel client create
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
display_channel_release_item: not pushed (101)
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much
fill_mask: fill_mask not doing much

...


Y.

>
>> Y.
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel