[Spice-devel] [PATCH spice-gtk 3/3] Make auto-usbredir a session setting rather then a per display setting

[Hans de Goede]

Hi,

On 10/07/2011 02:39 PM, Marc-André Lureau wrote:
>

<snip>

>> @@ -1234,6 +1223,13 @@ static void
>> spice_display_class_init(SpiceDisplayClass *klass)
>>                                 G_PARAM_CONSTRUCT |
>>                                 G_PARAM_STATIC_STRINGS));
>>
>> +    /**
>> +     * SpiceDisplay:auto-usbredir:
>> +     *
>> +     * Automatically redirect newly plugged in USB devices. Note the
>> auto
>> +     * redirection only happens when the widget has keyboard focus.
>> +     *
>> +     **/
>
> Can you also mark it as getting deprecated, and gtksession should be used instead?

Well that would mean adding:

  *
  * Since: 0.9.1
  *
  * Deprecated: 0.9.1: Use #SpiceGtkSession:auto-usbredir: instead.

Which is a bit weird. If you want to go that way, we can just drop it :)

But first we then need to teach spicy how to deal with properties on the
GtkSession (not a big deal, but needs doing first).

If we go that way I'll also add a deprecated note for auto-clipboard.

Once I hear from you what you think about just dropping SpiceDisplay:auto-usbredir:
I'll go implement whatever we agree on :)

Regards,

Hans