[Spice-devel] [PATCH spice-gtk 4/7] SpiceDisplay: mark clipboard properties and functions as deprecated

[Hans de Goede]

Hi,

On 10/10/2011 04:07 PM, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
>> We discussed adding the deprecation notes on Fri 7 Oct, I pushed the
>> initial
>> (and acked) patch moving the clipboard stuff to git.freedesktop.org
>> on Thu 6 Oct.
>
> The day I gave a ack with the deprecation comment. You shouldn't have pushed before.
>
>>
>> Sorry I can do a lot of things but I don't do time travel. Also I
>> must say I'm
>> a bit unhappy about to tone of this latest review. I've been spending
>> quite a bit
>
> I apologize

Apologies accepted.

 > I am also unhappy seeing that my comments are ignored. I spend also a great amount of time reviewing patches.

Sorry about pushing that one patch to soon. You're reviews are appreciated and I'm not
ignoring them, AFAIK I've been faithfully addressing every single remark. Including
the deprecation remark, although maybe a bit late.

How do you want to move forward with the deprecation marking + adding Since notes to
spice-gtk-session patches, shall I merge them, or do you want to keep them as 2 separate
patches?

Regards,

Hans