[Spice-devel] [PATCH] server: fix function prototypes

Alon Levy alevy at redhat.com
Mon Sep 5 00:08:04 PDT 2011


On Mon, Sep 05, 2011 at 07:54:04AM +0200, Christophe Fergeau wrote:
> On Mon, Sep 05, 2011 at 08:20:55AM +0300, Alon Levy wrote:
> > On Mon, Sep 05, 2011 at 03:19:50AM +0200, Christophe Fergeau wrote:
> > > Several functions in server/ were not specifying an argument list,
> > > ie they were declared as void foo(); When compiling with
> > > -Wstrict-prototypes, this leads to:
> > > test_playback.c:93:5: erreur: function declaration isn’t a prototype
> > > [-Werror=strict-prototypes]
> > 
> > ACK
> 
> Pushed, but as usual I screwed up and pushed unrelated stuff, hopefully
> this will learn me to be much more careful when pushing... The 4 unrelated
> commits I pushed should be ok, except for Marc-André's fix for some
> multiscreen bug, I forgot if this one got reviewed...

Generally (I think after doing the same mistake) I try to start from master, and
cherry-pick my acked commits, and then push, instead of pushing from a development
branch.

> 
> Christophe



> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel



More information about the Spice-devel mailing list