[Spice-devel] [PATCH 1/7] Fix line length errors in main_channel

[Dan McGee]

On Thu, Jan 19, 2012 at 3:14 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> On Thu, Jan 19, 2012 at 02:09:58PM -0600, Dan McGee wrote:
>> These are all existing errors; fix them so they don't block future
>> commits in this file unnecessarily.
>>
>>     error (1): length @ server/main_channel.c +369
>>     error (2): length @ server/main_channel.c +444
>>     error (3): length @ server/main_channel.c +764
>>     error (4): length @ server/main_channel.c +932
>>     error (5): length @ server/main_channel.c +1044
>
> If there's a general desire to have a max line length, then it
> would be worth adding to cfg.mk to create a new rule for the
> 'make syntax-check' sanity test.

As an FYI, I was following 2.2 in
http://spice-space.org/docs/spice_style.pdf, as well as having the
recommended git pre-commit hook enabled [1] when I made this one.

I'd agree that it should probably be enforced by this target I just
learned about ('syntax-check'), but that belongs in a different patch
at the very least, so I'd like to hear some input first.

-Dan

[1] http://spice-space.org/download/spice-pre-commit