[Spice-devel] [PATCH] Don't use "hw:0, 0" for recording with alsa

Alon Levy alevy at redhat.com
Tue Jan 31 08:36:01 PST 2012


On Tue, Jan 31, 2012 at 04:46:01PM +0100, Christophe Fergeau wrote:
> We currently hardcode this device when spicec needs to record with
> alsa. However, this doesn't interact well with PulseAudio, which
> means that if something is already using the recording device, spicec
> won't be able to open it again.
> Using "default" as the device will let spicec use the PulseAudio
> alsa support and will avoid this issue.

ACK

> ---
>  client/x11/record.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/client/x11/record.cpp b/client/x11/record.cpp
> index bd76cee..535a8c9 100644
> --- a/client/x11/record.cpp
> +++ b/client/x11/record.cpp
> @@ -96,7 +96,7 @@ bool WaveRecorder::init(uint32_t sampels_per_sec,
>                          uint32_t channels)
>  {
>      const int frame_size = WaveRecordAbstract::FRAME_SIZE;
> -    const char* pcm_device = "hw:0,0"; // "default" ???
> +    const char* pcm_device = "default";
>      snd_pcm_format_t format;
>      int err;
>  
> -- 
> 1.7.7.6
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list