[Spice-devel] [PATCH 1/2] Add log for invalid/expired tickets

[Yaniv Kaul]

On 03/02/2012 05:52 PM, Christophe Fergeau wrote:
> Currently, when a ticket has already expired, or is invalid, there is
> no qemu log to tell what went wrong. This commit adds such a log.
>
> Fixes rhbz#787669

How 'heavy' is this red_printf? Can this cause DoS (if there's no print 
limiting to it) ?
Y.

> ---
>   server/reds.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 797d9d5..3a98456 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -1860,6 +1860,11 @@ static void reds_handle_ticket(void *opaque)
>           }
>
>           if (expired || strncmp(password, taTicket.password, SPICE_MAX_PASSWORD_LENGTH) != 0) {
> +            if (expired) {
> +                red_printf("Ticket has expired");
> +            } else {
> +                red_printf("Invalid password");
> +            }
>               reds_send_link_result(link, SPICE_LINK_ERR_PERMISSION_DENIED);
>               reds_link_free(link);
>               return;