[Spice-devel] [PATCH] Add casts for compatibility purposes

Marc-André Lureau marcandre.lureau at gmail.com
Wed Mar 14 15:06:26 PDT 2012


Hi

On Tue, Feb 14, 2012 at 9:41 AM, Alon Levy <alevy at redhat.com> wrote:
> On Mon, Feb 13, 2012 at 01:53:32PM -0600, Dan McGee wrote:
>> Some non-Linux platforms return a (caddr_t *) result for the return
>> value of mmap(), which is very unfortunate. Add a (void *) cast to
>> explicitly avoid the warning when compiling with -Werror.
>>
>> For the IO vector related stuff, signed vs. unsigned comes into play so
>> adding a (void *) cast here is technically correct for all platforms.
>>
>
> ACK. I'll push.

Unfortunately, this also causes a warning:

marshaller.c:528:50: error: pointer of type 'void *' used in
arithmetic [-Werror=pointer-arith]

casting to uint8_t* instead?

-- 
Marc-André Lureau


More information about the Spice-devel mailing list