[Spice-devel] [PATCH v2] cleanup x11 library detection for building client

[Christophe Fergeau]

Hey Nahum,

On Thu, May 03, 2012 at 12:32:19PM -0400, Nahum Shalman wrote:
> Consolidate two separate chunks of library hunting that depend on the
> same check.
> 
> Check if we're actually building the client before looking for
> client only libraries.
> 
> Hide some of the final output if we're not building the client.
> ---
> I think this should address the rest of the concerns about
> the previous version of this patch.

Patch looks good to me, and worked with and without --disable-client. I'll
push it later today, just waiting a little bit in case someone has more
comments. I'll fold the patch below when pushing to remove some unwanted
blank lines in the summary.

Thanks for sending this patch and addressing my comments!

Christophe


diff --git a/configure.ac b/configure.ac
index 6853d05..66f9d12 100644
--- a/configure.ac
+++ b/configure.ac
@@ -482,7 +482,7 @@ echo "
         python:                   ${PYTHON}
 
         Build Spice client:       ${enable_client}
-" ; if test "x$enable_client" == "xyes"; then echo "
+" ; if test "x$enable_client" == "xyes"; then echo "\
         Have XRANDR 1.2:          ${have_xrandr12}
 
         Have Xinerama:            ${have_xinerama}
@@ -492,7 +492,7 @@ echo "
         OpenGL:                   ${enable_opengl}
 
         GUI:                      ${enable_gui}
-" ; fi ; echo "
+" ; fi ; echo "\
         Support tunneling:        ${enable_tunnel}
 
         Smartcard:                ${enable_smartcard}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120504/f5073246/attachment-0001.pgp>