[Spice-devel] [spice-gtk Win32 PATCH 1/7] Move "err" variable definition to beginning of the function

[Marc-André Lureau]

ack

On Mon, May 7, 2012 at 3:15 PM, Uri Lublin <uril at redhat.com> wrote:
> This fixes the following compilation error:
> channel-usbredir.c: In function 'spice_usbredir_channel_connect_device_async':
> channel-usbredir.c:313:9: error: jump skips variable initialization [-Werror=jump-misses-init]
> ---
>  gtk/channel-usbredir.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c
> index 8b2d2f4..3d57152 100644
> --- a/gtk/channel-usbredir.c
> +++ b/gtk/channel-usbredir.c
> @@ -297,6 +297,9 @@ void spice_usbredir_channel_connect_device_async(
>  {
>     SpiceUsbredirChannelPrivate *priv = channel->priv;
>     GSimpleAsyncResult *result;
> +#if ! USE_POLKIT
> +    GError *err = NULL;
> +#endif
>
>     g_return_if_fail(SPICE_IS_USBREDIR_CHANNEL(channel));
>     g_return_if_fail(device != NULL);
> @@ -335,7 +338,6 @@ void spice_usbredir_channel_connect_device_async(
>                                   channel);
>     return;
>  #else
> -    GError *err = NULL;
>     if (!spice_usbredir_channel_open_device(channel, &err)) {
>         g_simple_async_result_take_error(result, err);
>         libusb_unref_device(priv->device);
> --
> 1.7.7.6
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau