[Spice-devel] server RFC: 2 significant build-time changes

Alon Levy alevy at redhat.com
Tue Nov 27 23:39:30 PST 2012


> On Fri, Nov 23, 2012 at 04:58:23PM +0100, Christophe Fergeau wrote:
> > Hey,
> > 
> > This patch series introduces 2 build system changes that are worth
> > some
> > attention. The first one disables client build by default as it's
> > deprecated,
> > and the second patch adds a dependency on glib2. Both of these
> > patches
> > are steps in the right direction in my opinion, but I'm happy with
> > dropping them if there is some disagreement over that ;)
> > 
> > The third patch uses the glib string API in a very specific place,
> > there
> > are probably cleanup that can be done in many places by replacing
> > home-grown stuff with glib replacements. I also was not sure where
> > to add the glib dep, it may be more appropriate to have it in
> > spice-common
> > so that we can use it in common/mem.[ch] for example.
> 
> Unless someone comes forward with a use case for libspice-server.so
> where glib2 would be a serious blocker, I think this is a good move.
> It ought to let you remove / simplify alot of cross-platform stuff
> spice currently reinvents itself.

Also makes it possible sometime in the future to gobject-introspectify spice-server if only for testing.

> 
> Daniel
> --
> |: http://berrange.com      -o-
> |   http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-
> |            http://virt-manager.org :|
> |: http://autobuild.org       -o-
> |        http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-
> |      http://live.gnome.org/gtk-vnc :|
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list