[Spice-devel] [vdagent-win PATCH] vdservice: reset vdagent stop event after wait

Hans de Goede hdegoede at redhat.com
Tue Feb 26 08:32:00 PST 2013


ACK.

On 02/26/2013 05:04 PM, Arnon Gilboa wrote:
> vdagent terminates when the global event is set by vdservice. vdservice is also
> responsible to reset the event in any case, without trusting vdagent to do so.
> Otherwise, it may terminate the following vdagent instance immediately as well.
>
> Regression was due to commit 2d03cc.
>
> rhbz #868254
> ---
>   vdservice/vdservice.cpp |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
> index a899ae1..90a3b26 100644
> --- a/vdservice/vdservice.cpp
> +++ b/vdservice/vdservice.cpp
> @@ -801,6 +801,7 @@ bool VDService::kill_agent()
>               break;
>           }
>       }
> +    ResetEvent(_agent_stop_event);
>       CloseHandle(proc_handle);
>       CloseHandle(_agent_proc_info.hThread);
>       ZeroMemory(&_agent_proc_info, sizeof(_agent_proc_info));
>


More information about the Spice-devel mailing list